Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2002-09

CVS changes

14 messages · 3 people ·

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Mattias Gaertner
to Andrew Johnson: On Fri, 13 Sep 2002 16:25:35 +0200 Looks like someone broke all Graphics editors an hour…
Show quoted text 17 lines
On Fri, 13 Sep 2002 16:25:35 +0200 "Michal Bukovjan" Wrote : >>Also - where would our nice TColor property editor dialog go? >> >> >>If you mean what file, that would be - >> >>designer/graphpropedits.pp >> >No, I mean it does not appear anymore in OI with the current >CVS. Looks like someone broke all Graphics editors an hour ago.., along TStatusbar. It looks like they are working on improving the Property Editors etc, and making a Interface Dependent Statusbar. It'll probably be fixed soon, as I don't see that much wrong, I think it may be whoever did it just didn't catch that the changes broke anything.

As soon as I saw your mail, I updated and I got the errors. Michal, I guess, you have extended the uses clause of propedits with LazarusIDEStrConsts and ControlSelection. You must not do that. propedits.pp, graphpropedits.pas and objectinspector.pp are _not_ an internal part of the IDE. They built a world of their own, so that people can use them in their programs as tools. That's why they are under LGPL. Adding these units to the uses clause, will reorder the initialization sections upside down. If you need access to the designer/controlselection, plz add a hook to the TPropertyEditorHook.

Mattias

Reply by email

Michal Bukovjan

Hi,

Thanks to MoveWindowOrg stuff, I removed the graphic control hackaround
- TSpeedButton are now drawing via proper mechanism. There is only some more flickering, I wonder where this comes from.

Please notice that upon exit, sometimes the buttons are not drawn (this happened even with workaround). Looks like when we remove some draw messages, we do not do that quite right.

Also - where would our nice TColor property editor dialog go?

Michal

Reply by email

Andrew Johnson

On Fri, 13 Sep 2002 15:45:06 +0200
"Michal Bukovjan" wrote:

Hi,

Thanks to MoveWindowOrg stuff, I removed the graphic control hackaround - TSpeedButton are now drawing via proper mechanism. There is only some more flickering, I wonder where this comes from.

The extra flickering is twofold - GDK sends multiple messages where Win32 does not, and DoubleBuffering isn't finished yet, so it redraws the whole button on every mouse over etc. With the changes that have been made, it probably won't be too long before this will be taken care of, though I can't be positive.

Also - where would our nice TColor property editor dialog go?

If you mean what file, that would be -

designer/graphpropedits.pp

Andrew

_________________________________________________________________ Send and receive Hotmail on your mobile device: http://mobile.msn.com

Reply by email

Andrew Johnson
Show quoted text 8 lines
>Also - where would our nice TColor property editor dialog go? > > >If you mean what file, that would be - > >designer/graphpropedits.pp > No, I mean it does not appear anymore in OI with the current >CVS.

Looks like someone broke all Graphics editors an hour ago.., along TStatusbar. It looks like they are working on improving the Property Editors etc, and making a Interface Dependent Statusbar. It'll probably be fixed soon, as I don't see that much wrong, I think it may be whoever did it just didn't catch that the changes broke anything.

Andrew

_________________________________________________________________ MSN Photos is the easiest way to share and print your photos: http://photos.msn.com/support/worldwide.aspx

Reply by email

Michal Bukovjan
to Andrew Johnson: On Fri, 13 Sep 2002 15:45:06 +0200 The extra flickering is twofold - GDK sends multiple…
Andrew Johnson wrote 15 lines
On Fri, 13 Sep 2002 15:45:06 +0200 "Michal Bukovjan" wrote: Hi, > Thanks to MoveWindowOrg stuff, I removed the graphic control > hackaround - TSpeedButton are now drawing via proper mechanism. > There is only some more flickering, I wonder where this comes from. The extra flickering is twofold - GDK sends multiple messages where Win32 does not, and DoubleBuffering isn't finished yet, so it redraws the whole button on every mouse over etc. With the changes that have been made, it probably won't be too long before this will be taken care of, though I can't be positive.

Great.

Show quoted text 9 lines
> Also - where would our nice TColor property editor dialog go? If you mean what file, that would be - designer/graphpropedits.pp

No, I mean it does not appear anymore in OI with the current CVS.

Michal

Reply by email

Andrew Johnson
And why does not TStatusBar.SimplePanel=false work anymore?

Looks like he is trying to make TStatusBar Interface dependent.. so the code for if it is false no longer exists, until he has it finished in the interface. This is why I didn't bother doing it when you asked if we could, because of how hard making it work in multiple panel mode, and still supporting Alignment etc would be..

Obviously once it does work it should be nicer, but I am not so certain he should have completely dumped the existing hack until it was full working but.. If he can get the basics working quickly I don't suppose it is to big of a deal.

Andrew

_________________________________________________________________ Join the world�s largest e-mail service with MSN Hotmail. http://www.hotmail.com

Reply by email

Michal Bukovjan
to Andrew Johnson: On Fri, 13 Sep 2002 16:25:35 +0200 Looks like someone broke all Graphics editors an hour…
Mattias Gaertner wrote 70 lines
On Fri, 13 Sep 2002 17:57:53 +0200 Michal Bukovjan wrote: >Mattias Gaertner wrote: > > > >>On Fri, 13 Sep 2002 10:41:18 -0400 >>"Andrew Johnson" wrote: >> >> >> >> >> >>>On Fri, 13 Sep 2002 16:25:35 +0200 >>>"Michal Bukovjan" Wrote : >>> >>> >>> >>> >>> >>>>>Also - where would our nice TColor property editor dialog go? >>>>> >>>>> >>>>>If you mean what file, that would be - >>>>> >>>>>designer/graphpropedits.pp >>>>> >>>>> >>>>> >>>>> >>>>> >>>>No, I mean it does not appear anymore in OI with the current >CVS. >>>> >>>> >>>> >>>> >>>Looks like someone broke all Graphics editors an hour ago.., along >>>TStatusbar. It looks like they are working on improving the Property Editors >>>etc, and making a Interface Dependent Statusbar. It'll probably be fixed >>>soon, as I don't see that much wrong, I think it may be whoever did it just >>>didn't catch that the changes broke anything. >>> >>> >>> >>> >>As soon as I saw your mail, I updated and I got the errors. >>Michal, I guess, you have extended the uses clause of propedits with LazarusIDEStrConsts and ControlSelection. You must not do that. >>propedits.pp, graphpropedits.pas and objectinspector.pp are _not_ an internal part of the IDE. They built a world of their own, so that people can use them in their programs as tools. That's why they are under LGPL. >>Adding these units to the uses clause, will reorder the initialization sections upside down. >>If you need access to the designer/controlselection, plz add a hook to the TPropertyEditorHook. >> >> >>Mattias >> >> >> >> >I see... I did not realize such relations. I thought it was because of >CVS update. >Sorry, fixed in CVS now. > > And why does not TStatusBar.SimplePanel=false work anymore?

Perhaps I could revert the change for now...
It did not work properly anyway. I would like to switch this to TCustomPanel / TPanel implementations, the same way it works in Kylix. It is difficult to test, though, as editing a collection does not work at the moment.

I'll work on it some more and either commit a fix or revert the change.

Michal

Reply by email

Mattias Gaertner
to Andrew Johnson: On Fri, 13 Sep 2002 16:25:35 +0200 Looks like someone broke all Graphics editors an hour…
Show quoted text 45 lines
Mattias Gaertner wrote: >On Fri, 13 Sep 2002 10:41:18 -0400 >"Andrew Johnson" wrote: > > > >>On Fri, 13 Sep 2002 16:25:35 +0200 >>"Michal Bukovjan" Wrote : >> >> >> >>>>Also - where would our nice TColor property editor dialog go? >>>> >>>> >>>>If you mean what file, that would be - >>>> >>>>designer/graphpropedits.pp >>>> >>>> >>>> >>>No, I mean it does not appear anymore in OI with the current >CVS. >>> >>> >>Looks like someone broke all Graphics editors an hour ago.., along >>TStatusbar. It looks like they are working on improving the Property Editors >>etc, and making a Interface Dependent Statusbar. It'll probably be fixed >>soon, as I don't see that much wrong, I think it may be whoever did it just >>didn't catch that the changes broke anything. >> >> > >As soon as I saw your mail, I updated and I got the errors. >Michal, I guess, you have extended the uses clause of propedits with LazarusIDEStrConsts and ControlSelection. You must not do that. >propedits.pp, graphpropedits.pas and objectinspector.pp are _not_ an internal part of the IDE. They built a world of their own, so that people can use them in their programs as tools. That's why they are under LGPL. >Adding these units to the uses clause, will reorder the initialization sections upside down. >If you need access to the designer/controlselection, plz add a hook to the TPropertyEditorHook. > > >Mattias > > I see... I did not realize such relations. I thought it was because of CVS update. Sorry, fixed in CVS now.

And why does not TStatusBar.SimplePanel=false work anymore?

Mattias

Reply by email

Michal Bukovjan
to Andrew Johnson: On Fri, 13 Sep 2002 18:23:36 +0200 Looks like he is trying to make TStatusBar Interface…
Michal Bukovjan wrote 28 lines
Andrew Johnson wrote: > On Fri, 13 Sep 2002 18:23:36 +0200 > "Mattias Gaertner" wrote: > >> And why does not TStatusBar.SimplePanel=false work anymore? > > > > Looks like he is trying to make TStatusBar Interface dependent.. so > the code for if it is false no longer exists, until he has it > finished in the interface. This is why I didn't bother doing it when > you asked if we could, because of how hard making it work in multiple > panel mode, and still supporting Alignment etc would be.. > > Obviously once it does work it should be nicer, but I am not so > certain he should have completely dumped the existing hack until it > was full working but.. If he can get the basics working quickly I > don't suppose it is to big of a deal. > > Andrew Actually I am trying to do this interface independent. I commited that by accident, it was not ready... As I said in other mail, I'll either make it work or revert it in a while. Michal

This will take more time than I actually thought - it seems to be not so simple.
So I revert my last changes to statusbar. It should work again now.

Michal

Reply by email

Michal Bukovjan
to Andrew Johnson: On Fri, 13 Sep 2002 15:45:06 +0200 I am not sure if its your new code, or something wrong…
Andrew Johnson wrote 35 lines
On Fri, 13 Sep 2002 15:45:06 +0200 "Michal Bukovjan" wrote: > Thanks to MoveWindowOrg stuff, I removed the graphic control > hackaround - TSpeedButton are now drawing via proper mechanism. > There is only some more flickering, I wonder where this comes from. > > Please notice that upon exit, sometimes the buttons are not drawn > (this happened even with workaround). Looks like when we remove some > draw messages, we do not do that quite right. I am not sure if its your new code, or something wrong in my TextRect or more problems with Clipping, but since your changes to SpeedButton I have noticed bizaare behaviour with SpeedButtons on Panel's or ScrollBox. The strangeness can easily be seen in TCollectionItem Property Editor, for instance editing a Statusbar's Panels, when you move over the add button, the Delete Button's Text is, well, clipped I guess to the Rectange of the Add button. It gets even wierder. I had a Form with two speedbuttons in it, and a panel with two speedbuttons on IT. After moving my cursor over one of the buttons on the panel NONE of the buttons were updating on Mouse over or Mouse click. This doesn't apear to a problem with just Panel either, as I said, it also happens with speedbutton's on Scrollbox's, for instance one button the caption completely disapeared on Mouse over.. and it was the only speedbutton with a caption. Like I say, I don't know if this is a problem in your code, or a problem made apparent because of your code, but either way if you have any ideas on this.. its getting frustrating as I never know when the buttons will work or not, or when they will just act funny, and I can't figure out where the problem is as of yet. Andrew

I noticed the problem, too, looks like clipping.
Note that what I commited is not new code, just a cleanup since MoveWindowOrg is now supposedly working - therefore, we get normal painting for TGraphicControl right now. The cleanup included removal of a special code (ugly hack) for TSpeedButton that was there just to make it work, which is redundant now, and supposedly some errors are therefore exposed and found.

There were drawing problems even before, now they get more transparent. I would expect that the problem is indeed with clipping, and possibly with ClientRect not being set correctly under some curcumstances. I will have time to look at the SpeedButton code after the weekend.

The problems do not occur on the component pallette, so perhaps they are related to being TPanel as parent...

And BTW, I just refixed TCollection property editor - the Listbox should not be multiselect (maybe later). This was yet another inadverent commit with my experiment (DOH!)

Michal

Reply by email

Michal Bukovjan
to Andrew Johnson: On Fri, 13 Sep 2002 16:25:35 +0200 Looks like someone broke all Graphics editors an hour…
Mattias Gaertner wrote 40 lines
On Fri, 13 Sep 2002 10:41:18 -0400 "Andrew Johnson" wrote: >On Fri, 13 Sep 2002 16:25:35 +0200 >"Michal Bukovjan" Wrote : > > > >>>Also - where would our nice TColor property editor dialog go? >>> >>> >>>If you mean what file, that would be - >>> >>>designer/graphpropedits.pp >>> >>> >>> >>No, I mean it does not appear anymore in OI with the current >CVS. >> >> >Looks like someone broke all Graphics editors an hour ago.., along >TStatusbar. It looks like they are working on improving the Property Editors >etc, and making a Interface Dependent Statusbar. It'll probably be fixed >soon, as I don't see that much wrong, I think it may be whoever did it just >didn't catch that the changes broke anything. > > As soon as I saw your mail, I updated and I got the errors. Michal, I guess, you have extended the uses clause of propedits with LazarusIDEStrConsts and ControlSelection. You must not do that. propedits.pp, graphpropedits.pas and objectinspector.pp are _not_ an internal part of the IDE. They built a world of their own, so that people can use them in their programs as tools. That's why they are under LGPL. Adding these units to the uses clause, will reorder the initialization sections upside down. If you need access to the designer/controlselection, plz add a hook to the TPropertyEditorHook. Mattias

I see... I did not realize such relations. I thought it was because of CVS update.
Sorry, fixed in CVS now.

Michal

Reply by email

Andrew Johnson
Show quoted text 7 lines
Thanks to MoveWindowOrg stuff, I removed the graphic control hackaround - TSpeedButton are now drawing via proper mechanism. There is only some more flickering, I wonder where this comes from. Please notice that upon exit, sometimes the buttons are not drawn (this happened even with workaround). Looks like when we remove some draw messages, we do not do that quite right.

I am not sure if its your new code, or something wrong in my TextRect or more problems with Clipping, but since your changes to SpeedButton I have noticed bizaare behaviour with SpeedButtons on Panel's or ScrollBox. The strangeness can easily be seen in TCollectionItem Property Editor, for instance editing a Statusbar's Panels, when you move over the add button, the Delete Button's Text is, well, clipped I guess to the Rectange of the Add button. It gets even wierder. I had a Form with two speedbuttons in it, and a panel with two speedbuttons on IT. After moving my cursor over one of the buttons on the panel NONE of the buttons were updating on Mouse over or Mouse click. This doesn't apear to a problem with just Panel either, as I said, it also happens with speedbutton's on Scrollbox's, for instance one button the caption completely disapeared on Mouse over.. and it was the only speedbutton with a caption.

Like I say, I don't know if this is a problem in your code, or a problem made apparent because of your code, but either way if you have any ideas on this.. its getting frustrating as I never know when the buttons will work or not, or when they will just act funny, and I can't figure out where the problem is as of yet.

Andrew

_________________________________________________________________ MSN Photos is the easiest way to share and print your photos: http://photos.msn.com/support/worldwide.aspx

Reply by email

Michal Bukovjan
to Andrew Johnson: On Fri, 13 Sep 2002 18:23:36 +0200 Looks like he is trying to make TStatusBar Interface…
Andrew Johnson wrote 18 lines
On Fri, 13 Sep 2002 18:23:36 +0200 "Mattias Gaertner" wrote: > And why does not TStatusBar.SimplePanel=false work anymore? Looks like he is trying to make TStatusBar Interface dependent.. so the code for if it is false no longer exists, until he has it finished in the interface. This is why I didn't bother doing it when you asked if we could, because of how hard making it work in multiple panel mode, and still supporting Alignment etc would be.. Obviously once it does work it should be nicer, but I am not so certain he should have completely dumped the existing hack until it was full working but.. If he can get the basics working quickly I don't suppose it is to big of a deal. Andrew

Actually I am trying to do this interface independent. I commited that by accident, it was not ready... As I said in other mail, I'll either make it work or revert it in a while.

Michal

Reply by email