I always figured that the TODO: thing would be used by GREPing the file, not seeing the writeln's so I would leave them commented or in asserts.
Should we add EACH procedure that needs to be done (has a TODO:) to the bug tracking software so we have a list? That way we can also see that some are being taken care of....
Shane
>> 05/09/00 11:57PM >>>
I am the guilty one for doing this. I went through all the units and changed the writeln's to Asserts. I didn't realize that there were the WARNINGS and ERRORS that were supposed to be writeln. Apparently I didn't see your previous email about this. But I think I have this fixed now. I went back and changed all the ERRORS and WARNINGS back to writelns. So that should be fixed now.
I didn't change the TODO's back. I wanted to find out what everyone thought about this first because having all those messages pouring all over the console window makes it very hard to debug code. I think it is just as easy to turn on tracing if you want to see the TODO messages. Also, someone can grep the directory for TODO to find them. So there are a couple of very easy ways to find them where they won't be in the way of debugging. But if everyone else thinks they should also be put back to writeln's, I will do that.
Curtis
Marc Weustink wrote 17 lines
Somebody just replaced all the writeln with asserts, great.
Now I can run through the code to find my debug messages I accidently left
behind to remove them.
Furthermore WARNINGS and ERRORS are also converted. They were ment to show
up all the time, not only for tracing. If you see an Warinig or Error,
something unexpected did occour and somebody should look after that.
Finally TODO's were ment to get ppls attention that there still existes
something to be implemented. Putting that behind a trace makes no sense and
therefore they can be removed.
As I said in an earlier message only some of the WriteLn I've put in the
code are worth being converted to a trace, all the others can be removed.
Besides that, it seems that I can't trace gtkobject.inc (or do you set the
asserrts on on a file base and not unit ?)
Marc
_________________________________________________________________ To unsubscribe: mail with
"unsubscribe" as the Subject
archives at http://www.miraclec.com/list_archives/lazarus