Mailing lists / fpc-pascal / 2016-09
6 messages · 3 people · –
Reply by email Subscribe to this list Your subscription
Read-only archive. Use j and k to move between messages.
Hi,
Somebody made a contribution via my Git mirror of the FPC repository. If somebody is interested in taking a look. The original author was notified that my Git mirror is an unofficial read-only repository.
https://github.com/graemeg/freepascal/pull/10
Regards,
Graeme
Somebody made a contribution via my Git mirror of the FPC repository.
File Changes
M packages/graph/src/win32/wincrt.pp (120)
Patch Links:
https://github.com/graemeg/freepascal/pull/10.patch https://github.com/graemeg/freepascal/pull/10.diff
Regards,
Graeme
That was me, Sorry about that, I did not realize it was a read only repository, I downloaded a fork of it to my desktop a while ago, so when I had a proposed change to it, I just made a pull request the way I normally do with git projects.
I have posted the issue here:
http://mantis.freepascal.org/view.php?id=30599 and have attached the file to it. I'm not really familiar with this system, so I hope I'm doing it right.
James Richters wroteThat was me, Sorry about that, I did not realize it was a read only repository, I downloaded a fork of it to my desktop a while ago, so when I had a proposed change to it, I just made a pull request the way I normally do with git projects.
No worries, many others assume the same. I started the "unofficial" git mirror as I find it easier to manage and produce my own patches - and all importantly, patches in multiple "feature branches" so as not to conflict with each other. I then submit those patches via FPC's Mantis system.
Maybe some day FPC will move over to Git. ;-)
Regards,
Graeme
Graeme Geldenhuys wroteNo worries, many others assume the same. I started the "unofficial" git mirror
Maybe it would help to mention the fact that it is unofficial in the description of your repository. You could also add something like "For submitting patches or bug reports, go to http://bugs.freepascal.org".
Jonas
Jonas Maebe wroteMaybe it would help to mention the fact
Indeed. I've updated the description. I hope this will make it clear from now onwards. Now if anybody actually reads such descriptions, that's another matter. ;-)
Regards,
Graeme