Hello,

Let's say I have a function that some of it's code (or all) can be used in more then one location inside the function itself. I can make a nested function with the code and set it to inline, make it normal, or make a recursion with it.

What's the best practice in your opinion to take, and why ?

Thanks,
Ido

You can make a function inside the function.

Like this:

function Test: Integer;
var
  i: Integer
  procedure IncI(aIncI: Integer);
  begin
    i := i +aIncI;
  end;
begin
  i := 1;
  while i <= 100 do
    IncI(i);
  Result := i;
end;

This make an geometric progression in i.

Recursion won't help you here, because recursion is something like the following:

function factorial(aValue: LongInt): LongInt;
begin
   if aValue <= 1 then
     Result := 1
   else
     Result := factorial(aValue - 1) * aValue;
end;

Whether you inline the function or not depends on whether it's a complex function or not. Something like

function foo(aValue: LongInt): LongInt;
begin
   Result := aValue * 6 + 5 - SomeParam;
end;

can definitely be declared inline. You just need to keep in mind that when inlining a function the function call will be replaced by the function's/procedure's body so the code size will increase (no, you don't need to pay attention for duplicate variable names).

Regards,
Sven

‎Thanks Sven, then I think I'll work with the nested function as a "normal" function rather then inline or recursive one.

Ido

______________________________**_________________ fpc-pascal maillist - http://lists.freepascal.org/**mailman/listinfo/fpc-pascal<http://lists.freepascal.org/mailman/listinfo/fpc-pascal>

Inline: http://www.freepascal.org/docs-html/ref/refsu64.html Recursion: http://wiki.freepascal.org/Recursion

2012/2/7 ik :