Hi,

Maybe it's how it's supposed to be but if use :

compareStr( 'hello', 'hello-bye' )

I get 0, so they are equal.

If one string is bigger than the other they should be different, isn't it?

Otherways what can I use to check if two ansistrings are different?

TIA, Ivan

I think so, too... but I don't have time to check this now, sorry, hopefully somebody else has.

Otherways what can I use to check if two ansistrings are different?

You can just use "=" for ShortString, AnsiString and WideString comparisons. "=" just doesn't work for PChar or PWideChar strings.

- Sebastian

I think this may be a bug in the compareStr function of sysUtils. I have tested the compareStr of sysUtils, and the compStr of the Strings unit. The Strings unit seems to do the test ok, and the result: 'hello' < 'hello-byte'.

cheers
James

program compare;
(*
uses
   sysUtils;
*)
uses
   Strings;
var
   (*
   str1: String;
   str2: String;
   *)
   str1: pChar;
   str2: pChar;
   r:    Integer;
begin
   str1 := 'hello';
   str2 := 'hello-bye';
   writeLn('str1 = ', str1);
   writeLn('str2 = ', str2);
   writeLn;
   r := strComp(str1, str2);
   if r < 0 then
      begin
         writeLn('str1 < str2');
      end
   else if r = 0 then
      begin
         writeLn('str1 = str2');
      end
   else
      begin
         writeLn('str1 > str2');
      end;
end.

_______________________________________________ fpc-pascal maillist - http://lists.freepascal.org/mailman/listinfo/fpc-pascal

In the fixbranch version I get -45 ?

(
version:
Free Pascal Compiler version 1.0.7 [2003/02/03] for i386 )

What version are you using ? I have fixed a bug report about this some time ago:

Revision 1.1.2.14 2002/11/28 20:13:10 michael
+ Fixed comparestr

Michael.

----- Original Message -----

That is strange, because I explicitly fixed it in the fixbranch, and the compiler I used has version 1.0.7.. I'll have to do some more checking, it seems.

Michael.

Sorry Michael,

I just found out that this happens in the 1.0.6 release version of FPC. It's fixed with a current snapshot.

Sorry again,
Ivan

Hello !

You found a bug : CompareStr( 'hello', 'hello-bye' ) = 0. It's already fixed in FPC 1.1 and 1.0.7, so I guess you're using FPC 1.0.6 or older. You can switch to FPC 1.0.7 or you can fix this by editing RTL sources :

At least for FPC 1.0.6, it's in file rtl/objpas/sysstr.inc, lines 109 - 110 :
You should replace these two lines

   if Count1 > Count2 then result := ord(s1[Count1 + 1])
   else result := -ord(s2[Count2 + 1]);

with

   if Count1 > Count2 then result := ord(s1[Count + 1])
   else result := -ord(s2[Count + 1]);

(that is, the "Count1" and "Count2" in array indexes should be replaced with "Count").

That's all for THAT bug.
But while reading the code of CompareStr function we can see there's another bug and it still exists in FPC 1.1 : CompareStr('hello', 'hello'#0'bye') will return 0 ! We can change the code in many ways to remove this disadvantage or we can state somewhere clearly that CompareStr doesn't work for strings that include #0 character inside (I myself would prefer the first option). This problem goes to the developers of FPC RTL.

Sorry for my poor english grammar.
Regards, Michalis Kamburelis

--------------r-e-k-l-a-m-a-----------------

Tanie bilety lotnicze!
http://samoloty.onet.pl

I have done this and run make (/usr/local/..rtl/ under Linux) but:

CompareStr('hello', 'hello wrld') still gives 0.

What am I missing here?

Thanks.

The official 1.0.6 had this bug. It's fixed now in the latest snapshots, as confirmed by the original poster.

Michael.

Well. But, what I want to do is just to correct this bug and stick with 1.0.6. Why do I have to update the hole compiler for just one bug when I could fix it with little editing?

Thank you.

ps.
If sombody has fixed this bug in fpc-1.0.6, please tells me how he/she did it.

You can simply download the latest RTL sources. from ftp://ftp.freepascal.org/pub/fpc/source
and compile it. You don't need the whole compiler for it.

Michael.

You can simply download the latest RTL sources. from ftp://ftp.freepascal.org/pub/fpc/source and compile it. You don't need the whole compiler for it.

Done, but:
CompareStr('hello', 'hello world') still gives 0.

Strange!!!

Sorry. That's Ok now.