Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-pascal / 2022-10

[Question] How to submit our patch?

5 messages · 3 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Jinyang He

We, a team working for Loongson, are ready to submit some patches which support a new architecture named LoongArch for FreePascal. [1] is one of repositories about LoongArch. LoongArch is a RISC architecture. The work of Loongson was based on MIPS in the past. So LoongArch is somewhat similar to MIPS. Of course, there are also commonalities with other RISC architectures such as aarch64, riscv, etc. Patches that support LoongArch also refer to many other architectures. I have to show my respect to the others who contributed FreePascal.

Which way can we submit these patches? I guess we should create a 'merge requests' in Gitlab. Is it correct? I hope to find some official documentation, or some discussion from the list. All answers are needed. Thanks.

[1] https://github.com/loongson

Reply by email

Christo Crause
to Jinyang He

On Mon, Oct 10, 2022 at 11:47 AM Jinyang He via fpc-pascal <

Show quoted text 17 lines
wrote: We, a team working for Loongson, are ready to submit some patches which support a new architecture named LoongArch for FreePascal. [1] is one of repositories about LoongArch. LoongArch is a RISC architecture. The work of Loongson was based on MIPS in the past. So LoongArch is somewhat similar to MIPS. Of course, there are also commonalities with other RISC architectures such as aarch64, riscv, etc. Patches that support LoongArch also refer to many other architectures. I have to show my respect to the others who contributed FreePascal. Which way can we submit these patches? I guess we should create a 'merge requests' in Gitlab. Is it correct? I hope to find some official documentation, or some discussion from the list. All answers are needed. Thanks. [1] https://github.com/loongson

Thank you for offering patches to support LoongArch in FPC.

Also send this message to the FPC developers' mailing list ( ), not all the compiler developers may be
monitoring this list.

Reply by email

Sven Barth
to Christo Crause

Christo Crause via fpc-pascal schrieb am
Mo., 10. Okt. 2022, 17:20:

Show quoted text 27 lines
On Mon, Oct 10, 2022 at 11:47 AM Jinyang He via fpc-pascal < > wrote: > We, a team working for Loongson, are ready to submit some patches which > support a new architecture named LoongArch for FreePascal. [1] is one of > repositories about LoongArch. LoongArch is a RISC architecture. The work > of Loongson was based on MIPS in the past. So LoongArch is somewhat > similar to MIPS. Of course, there are also commonalities with other RISC > architectures such as aarch64, riscv, etc. Patches that support LoongArch > also refer to many other architectures. I have to show my respect to the > others who contributed FreePascal. > > Which way can we submit these patches? I guess we should create a > 'merge requests' in Gitlab. Is it correct? I hope to find some official > documentation, or some discussion from the list. All answers are > needed. Thanks. > > [1] https://github.com/loongson Thank you for offering patches to support LoongArch in FPC. Also send this message to the FPC developers' mailing list ( ), not all the compiler developers may be monitoring this list.

I don't know of any compiler developer who isn't... 🤔 But fpc-devel would be more correct anyway due to the topic 😅

Regards,
Sven

Reply by email

Jinyang He
to Sven Barth

在 2022/10/11 0:52, Sven Barth via fpc-pascal 写道:

Show quoted text 42 lines
Christo Crause via fpc-pascal schrieb am Mo., 10. Okt. 2022, 17:20: On Mon, Oct 10, 2022 at 11:47 AM Jinyang He via fpc-pascal wrote: We, a team working for Loongson, are ready to submit some patches which support a new architecture named LoongArch for FreePascal. [1] is one of repositories about LoongArch. LoongArch is a RISC architecture. The work of Loongson was based on MIPS in the past. So LoongArch is somewhat similar to MIPS. Of course, there are also commonalities with other RISC architectures such as aarch64, riscv, etc. Patches that support LoongArch also refer to many other architectures. I have to show my respect to the others who contributed FreePascal. Which way can we submit these patches? I guess we should create a 'merge requests' in Gitlab. Is it correct? I hope to find some official documentation, or some discussion from the list. All answers are needed. Thanks. [1] https://github.com/loongson Thank you for offering patches to support LoongArch in FPC. Also send this message to the FPC developers' mailing list (), not all the compiler developers may be monitoring this list. I don't know of any compiler developer who isn't... 🤔 But fpc-devel would be more correct anyway due to the topic 😅

Hi, Christo and Sven,

I'll pay more attention to fpc-devel. Thanks for your answers, that's helpful. 😁

Thanks,

Jinyang

Reply by email

Sven Barth
to Jinyang He: We, a team working for Loongson, are ready to submit some patches which support a new…

Jinyang He via fpc-pascal schrieb am Mo.,
10. Okt. 2022, 11:47:

Show quoted text 15 lines
We, a team working for Loongson, are ready to submit some patches which support a new architecture named LoongArch for FreePascal. [1] is one of repositories about LoongArch. LoongArch is a RISC architecture. The work of Loongson was based on MIPS in the past. So LoongArch is somewhat similar to MIPS. Of course, there are also commonalities with other RISC architectures such as aarch64, riscv, etc. Patches that support LoongArch also refer to many other architectures. I have to show my respect to the others who contributed FreePascal. Which way can we submit these patches? I guess we should create a 'merge requests' in Gitlab. Is it correct? I hope to find some official documentation, or some discussion from the list. All answers are needed. Thanks. [1] https://github.com/loongson

First of thank you for your desire to contribute support for the Loongson architecture.

To answer your question, yes, a merge request is the best way, cause we can comment easier. Preferably this is done on GitLab, our main repository, but if it's really necessary youa can use GitHub as well, but you should notify us about the request then, cause at least I don't monitor our GitHub mirror.

Regarding the commits themselves: best split your commit up into the following parts:

- adding the new architecture (without any target OS) to the compiler
- adding the loongson-linux target to the compiler
- adding the loongson-linux target and the loongson architecture in general to the build utilities (fpmake and fpcmake)
- adding the RTL for loongson-linux
- changes to RTL/packages that are specific to the Loongson architecture in general
- changes to RTL/packages that are specific to the loongson-linux target
- regenerating the makefiles (a separate commit, cause that's rather "noisy")

Regards,
Sven

Reply by email