This patch fixes a bug in win32 threads. Warning: created in win32 :) (no idea about lineendings)
Ales
Mailing lists / fpc-devel / 2005-11
win32 patch for threads
4 messages · 3 people · –
- Ales Katona 2
- Florian Klaempfl 1
- Micha Nelissen 1
Reply by email Subscribe to this list Your subscription
Read-only archive. Use j and k to move between messages.
Ales Katona wroteThis patch fixes a bug in win32 threads. Warning: created in win32 :) (no idea about lineendings)
Aplied, also for wince and netware.
Show quoted text 39 lines
Ales
------------------------------------------------------------------------
Index: rtl/win32/tthread.inc
===================================================================
--- rtl/win32/tthread.inc (revision 1647)
+++ rtl/win32/tthread.inc (working copy)
@@ -97,7 +97,7 @@
{ TThread }
-function ThreadProc(ThreadObjPtr: Pointer): Integer;
+function ThreadProc(ThreadObjPtr: Pointer): Integer; stdcall;
var
FreeThread: Boolean;
Thread: TThread absolute ThreadObjPtr;
Index: rtl/inc/threadh.inc
===================================================================
--- rtl/inc/threadh.inc (revision 1647)
+++ rtl/inc/threadh.inc (working copy)
@@ -26,7 +26,7 @@
type
PEventState = pointer;
PRTLEvent = pointer; // Windows=thandle, other=pointer to record.
- TThreadFunc = function(parameter : pointer) : ptrint;
+ TThreadFunc = function(parameter : pointer) : ptrint; stdcall;
trtlmethod = procedure of object;
// Function prototypes for TThreadManager Record.
------------------------------------------------------------------------
_______________________________________________
fpc-devel maillist -
http://lists.freepascal.org/mailman/listinfo/fpc-devel
Florian Klaempfl wroteAplied, also for wince and netware.
Sorry, it seems I broke Unix and all non-stdcall-using platforms. This patch fixes that(apply after the first one) but it only {ifdefs} windows, not netware or others, so please add those as necessery.
Ales
This patch fixes a bug in win32 threads. Warning: created in win32 :) (no idea about…
This patch fixes a bug in win32 threads. Warning: created in win32 :) (no idea about lineendings)
There is no bug here, the function passed to the OS is in rtl/win32/systhrd.inc (ThreadMain) for win32, which has stdcall convention already. The procvar type you've modified is a regular fpc/pascal function.
Micha