Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2005-09

patch for GenericAnsiStrComp

3 messages · 3 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Vincent Snijders

Hi,

This patch fixes GenericAnsiStrComp when two equal strings are compared or two strings that are the same (abc, abc) upto the last char of the shortest (abc, abcd).

I could provide a test program for the test suite. Can you give an example where runtime behaviour is checked (compilling is not the issue here)?

Also, please take a look at the initialization order in win32\sysutils.pp

   InitWin32Widestrings;
   InitExceptions;       { Initialize exceptions. OS independent }
   InitInternational;    { Initialize internationalization settings }

InitWin32WideString sets win32 specific function for the widestring manager. InitInternational overwrites them with the generic ones. Maybe FPC_NOGENERICANSIROUTINES should be defined for win32 too.

Vincent.

Reply by email

Florian Klaempfl
to Vincent Snijders: This patch fixes GenericAnsiStrComp when two equal strings are compared or two strings…
Vincent Snijders wrote 5 lines
Hi, This patch fixes GenericAnsiStrComp when two equal strings are compared or two strings that are the same (abc, abc) upto the last char of the shortest (abc, abcd).

Applied.

Show quoted text 15 lines
I could provide a test program for the test suite. Can you give an example where runtime behaviour is checked (compilling is not the issue here)? Also, please take a look at the initialization order in win32\sysutils.pp InitWin32Widestrings; InitExceptions; { Initialize exceptions. OS independent } InitInternational; { Initialize internationalization settings } InitWin32WideString sets win32 specific function for the widestring manager. InitInternational overwrites them with the generic ones. Maybe FPC_NOGENERICANSIROUTINES should be defined for win32 too.

Fixed, thx.

Reply by email