Index: rtl/objpas/varutils.inc
Aded forgotten initialization
=================================================================== --- rtl/objpas/varutils.inc (revision 1083)
+++ rtl/objpas/varutils.inc (working copy)
@@ -359,6 +359,7 @@

     if ResVAR_OK then
       exit;
     Result^.DimCount:=Dim;

+ Result^.LockCount:=0;

     Result^.Flags:=psaElementFlags[VarType];
     Result^.ElementSize:=psaElementSizes[VarType];
     for i:=0 to Dim-1 do

Index: rtl/objpas/sysutils/sysstr.inc
Repaired AnsiCompareStr
=================================================================== --- rtl/objpas/sysutils/sysstr.inc (revision 1083) +++ rtl/objpas/sysutils/sysstr.inc (working copy) @@ -299,7 +299,7 @@

     Inc(S1);
     Inc(S2);
   Until (Result0) or (S1^=#0) or (S2^=#0);

- if Result=0 then
+ if Result0 then

     if s1=#0 then
       result:=1
     else

Index: fcl/db/dataset.inc
Aded FConstraints and TempBuffer only for possibility to compile my big project ported to fpc
=================================================================== --- fcl/db/dataset.inc (revision 1083)
+++ fcl/db/dataset.inc (working copy)
@@ -27,6 +27,7 @@

   FFieldDefs:=TFieldDefs.Create(Self);
   FFieldList:=TFields.Create(Self);
   FDataSources:=TList.Create;

+ FConstraints := TCheckConstraints.Create(Self); end;

@@ -40,6 +41,7 @@
   Active:=False;
   FFieldDefs.Free;
   FFieldList.Free;
+  FreeAndNil(FConstraints);
   With FDatasources do
     begin
     While Count>0 do
@@ -1882,3 +1884,9 @@
   FDataSources.Remove(ADataSource);
 end;
+Function TDataset.TempBuffer: PChar;
+
+begin
+  //!! To be implemented
+end;
+
Index: fcl/db/db.pp
===================================================================
--- fcl/db/db.pp        (revision 1083)
+++ fcl/db/db.pp        (working copy)
@@ -1044,6 +1044,7 @@
     procedure SetRecNo(Value: Longint); virtual;
     procedure SetState(Value: TDataSetState);
     function SetTempState(const Value: TDataSetState): TDataSetState;
+    function TempBuffer: PChar;
     procedure UpdateIndexDefs; virtual;
     property ActiveRecord: Longint read FActiveRecord;
     property CurrentRecord: Longint read FCurrentRecord;

Any reason to re-implement the tempbuffer? Or were you just using an older version?

regards,
Joost.

Joost van der Sluis wrote

Any reason to re-implement the tempbuffer? Or were you just using an older version?

Please give me more datails (history) about "tempbuffer".

I can look deeply into ZeosLib and find out why it needs tempbuffer. Patch with constraints and tempbuffer is really not important.

Petr

It seems that there are many delphi compatible components left that use tempbuffer. I have myself reintroduced this function instantly, becouse it is used in filtering/searching operations by my dataset component.
Since this function exists in delphi and it is used by some components, i see no reason not to have it in fpc.

Alex

But relying in a function that does nothing / not implemented / acts different from Delphi can lead to problems.

Luiz

> Any reason to re-implement the tempbuffer? Or were you just using an > older version? Please give me more datails (history) about "tempbuffer".

Well, it was an empty procedure. But no-one had a clue where it was used for. Probably it had something to do with some very old fpc-TDataset- descendents. So it got removed.

But if you can find a reason to keep it there... Maybe that ZEOS uses it?

I can look deeply into ZeosLib and find out why it needs tempbuffer. Patch with constraints and tempbuffer is really not important.

Ok, forget my last message then, i'll re-implement it.

Do you also know what it should do?

Regards,
Joost

Now i ZEOS, but TRxMemoryData use it for
record filtering.

Petr

Function TDataset.TempBuffer: PChar;
begin
  Result := FBuffers[FRecordCount];
end;

The result of this function is used in filtering/searching operations.

Alex