Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2005-08

patch for fixing bug 4117

4 messages · 3 people ·

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Dirk

Hi,

attached is a patch from Juergen Rathlev which *should* fixes bug 4117 and may fix 4234, too. It removes using of qword from fpreadpng.pp because qword seems to be buggy and may probably improve the performance of some functions, too, because it avoids redundant shifting operations.

Dirk Rathlev

Reply by email

Peter Vreman
to Dirk
you wrote 6 lines
Hi, attached is a patch from Juergen Rathlev which *should* fixes bug 4117 and may fix 4234, too. It removes using of qword from fpreadpng.pp because qword seems to be buggy and may probably improve the performance of some functions, too, because it avoids redundant shifting operations.

If qword is buggy then that needs to be fixed. Applying this patch will only hide the real bug in the compiler.

The compiler bug needs to be fixed first before this patch can be applied otherwise it is not reproducable anymore.

FYI i already analysed it a little a before my holiday, the bug only happends when optimization with -O2 is done.

Peter

Reply by email

Michael Van Canneyt
to Dirk: attached is a patch from Juergen Rathlev which *should* fixes bug 4117 and may fix 4234,…
Dirk wrote 6 lines
Hi, attached is a patch from Juergen Rathlev which *should* fixes bug 4117 and may fix 4234, too. It removes using of qword from fpreadpng.pp because qword seems to be buggy and may probably improve the performance of some functions, too, because it avoids redundant shifting operations.

Thank you, I reviewed and committed the patch.

Michael.

Reply by email

Michael Van Canneyt
to Peter Vreman: If qword is buggy then that needs to be fixed. Applying this patch will only hide the…
Peter Vreman wrote 16 lines
At 13:19 14-8-2005, you wrote: > Hi, > > attached is a patch from Juergen Rathlev which *should* fixes bug 4117 and > may fix 4234, too. It removes using of qword from fpreadpng.pp because > qword seems to be buggy and may probably improve the performance of some > functions, too, because it avoids redundant shifting operations. If qword is buggy then that needs to be fixed. Applying this patch will only hide the real bug in the compiler. The compiler bug needs to be fixed first before this patch can be applied otherwise it is not reproducable anymore. FYI i already analysed it a little a before my holiday, the bug only happends when optimization with -O2 is done.

Seems I was too fast for you :/

The patch created revision 859, so you can reproduce with version 858...

Michael.

Reply by email