take a implementation (datasource.inc):

With FDatalinks do
     begin
     For I:=0 to Count-1 do
       With TDatalink(Items[i]) do
         If Not VisualControl Then
           DataEvent(Event,Info);
     For I:=0 to Count-1 do
       With TDatalink(Items[i]) do
         If VisualControl Then
           DataEvent(Event,Info);
     end;

Am I missimg something or the check to VisualControl doesnt make sense? As far as i can see the code below has the same effect

With FDatalinks do
     begin
     For I:=0 to Count-1 do
       With TDatalink(Items[i]) do
         DataEvent(Event,Info);
     end;

Luiz

take a implementation (datasource.inc):

With FDatalinks do
     begin
     For I:=0 to Count-1 do
       With TDatalink(Items[i]) do
         If Not VisualControl Then
           DataEvent(Event,Info);
     For I:=0 to Count-1 do
       With TDatalink(Items[i]) do
         If VisualControl Then
           DataEvent(Event,Info);
     end;

Am I missimg something or the check to VisualControl doesnt make sense? As far as i can see the code below has the same effect

With FDatalinks do
     begin
     For I:=0 to Count-1 do
       With TDatalink(Items[i]) do
         DataEvent(Event,Info);
     end;

Luiz

No. First non visual components (such as detail datasets, lookup datasets) must get their event, and only then visual controls get an event.

The double loop is intentional.

Michael.

Thank you.
Now I can see the intention.

It seens that this procedure is called quite often. One approach to optimize could be inserting the items in FDataLinks in the appropriate order (Non visual first, visual in the end) and doing a simple loop without checks in DistributeEvent.
This would be done inside RegisterDataLink with a simple and safe alghoritm.

If you agree with the cited approach i can send the patch.

Luiz

----- Original Message -----