Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2004-08

bug in Changes.XXX file generation?

8 messages · 4 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Vincent Snijders

Hi,

I noticed that sometimes cvs-changes are not included in the Changes.lazarus file in fpc/logs.

For example there was no entry for the adding of:
http://www.freepascal.org/cgi-bin/viewcvs.cgi/projects/lazarus/components/im ages/imagesforlazarus.lpk

There was no entry for this commit:
http://www.freepascal.org/cgi-bin/viewcvs.cgi/projects/lazarus/ideintf/helpi ntf.pas.diff?r1=1.12&r2=1.13&sortby=date

I might have something to do with new directories added.

Vincent.

Reply by email

Tomas Hajny
to Vincent Snijders

On Thu, 26 Aug 2004 10:31:29 +0200, Vincent Snijders wrote

Show quoted text 12 lines
I noticed that sometimes cvs-changes are not included in the Changes.lazarus file in fpc/logs. For example there was no entry for the adding of: http://www.freepascal.org/cgi-bin/viewcvs.cgi/projects/lazarus/components/im ages/imagesforlazarus.lpk There was no entry for this commit: http://www.freepascal.org/cgi-bin/viewcvs.cgi/projects/lazarus/ideintf/helpi ntf.pas.diff?r1=1.12&r2=1.13&sortby=date I might have something to do with new directories added.

The detection of changes is based on the logs at the end of files, AFAIR, so changes in any files missing these logs are ignored. One more reason to make sure at least all source files contain this log...

Tomas

Reply by email

Peter Vreman
to Tomas Hajny
Show quoted text 20 lines
On Thu, 26 Aug 2004 10:31:29 +0200, Vincent Snijders wrote > I noticed that sometimes cvs-changes are not included in the > Changes.lazarus > file in fpc/logs. > > For example there was no entry for the adding of: > http://www.freepascal.org/cgi-bin/viewcvs.cgi/projects/lazarus/components/im > ages/imagesforlazarus.lpk > > There was no entry for this commit: > http://www.freepascal.org/cgi-bin/viewcvs.cgi/projects/lazarus/ideintf/helpi > ntf.pas.diff?r1=1.12&r2=1.13&sortby=date > > I might have something to do with new directories added. The detection of changes is based on the logs at the end of files, AFAIR, so changes in any files missing these logs are ignored. One more reason to make sure at least all source files contain this log...

The changelog is created using the tool cvs2cl. It uses the output of 'cvs log' to create the files. You can download the tool yourself and test whether it works correct.

Reply by email

Vincent Snijders
to Peter Vreman
Show quoted text 20 lines
-----Oorspronkelijk bericht----- Van: [mailto:fpc-devel- > On Thu, 26 Aug 2004 10:31:29 +0200, Vincent Snijders wrote >> I noticed that sometimes cvs-changes are not included in the >> Changes.lazarus >> file in fpc/logs. >> >> For example there was no entry for the adding of: >> http://www.freepascal.org/cgi- bin/viewcvs.cgi/projects/lazarus/components/im >> ages/imagesforlazarus.lpk >> >> There was no entry for this commit: >> http://www.freepascal.org/cgi- bin/viewcvs.cgi/projects/lazarus/ideintf/helpi >> ntf.pas.diff?r1=1.12&r2=1.13&sortby=date >> >> I might have something to do with new directories added. > > The detection of changes is based on the logs at the end of files,

AFAIR,

Show quoted text 8 lines
> so > changes in any files missing these logs are ignored. One more reason to > make > sure at least all source files contain this log... The changelog is created using the tool cvs2cl. It uses the output of 'cvs log' to create the files. You can download the tool yourself and test whether it works correct.

As far as I can see, the cvs log command needs a local version of the files before it can execute. Is this true?

If this is true, is this local version also updated hourly with cvs update -d -P?

Vincent.

Reply by email

Unknown author
to Vincent Snijders
Vincent Snijders wrote 34 lines
> -----Oorspronkelijk bericht----- > Van: [mailto:fpc-devel- > > On Thu, 26 Aug 2004 10:31:29 +0200, Vincent Snijders wrote > >> I noticed that sometimes cvs-changes are not included in the > >> Changes.lazarus > >> file in fpc/logs. > >> > >> For example there was no entry for the adding of: > >> http://www.freepascal.org/cgi- > bin/viewcvs.cgi/projects/lazarus/components/im > >> ages/imagesforlazarus.lpk > >> > >> There was no entry for this commit: > >> http://www.freepascal.org/cgi- > bin/viewcvs.cgi/projects/lazarus/ideintf/helpi > >> ntf.pas.diff?r1=1.12&r2=1.13&sortby=date > >> > >> I might have something to do with new directories added. > > > > The detection of changes is based on the logs at the end of files, AFAIR, > > so > > changes in any files missing these logs are ignored. One more reason to > > make > > sure at least all source files contain this log... > > The changelog is created using the tool cvs2cl. It uses the output of 'cvs > log' to create the files. You can download the tool yourself and test > whether it works correct. As far as I can see, the cvs log command needs a local version of the files before it can execute. Is this true? If this is true, is this local version also updated hourly with cvs update -d -P?

No.
New files will only appear in the changelog after midnight.

Michael.

Reply by email

Vincent Snijders
to Unknown author
Show quoted text 5 lines
> If this is true, is this local version also updated hourly with cvs update > -d -P? No. New files will only appear in the changelog after midnight.

I have no problem with that. But I fear that for the lazarus directory they are never added.

Can you check if the following directories exist in the local version? lazarus/ideintf
lazarus/lcl/widgetset

TIA,
Vincent.

Reply by email

Unknown author
to Vincent Snijders
Vincent Snijders wrote 13 lines
On Thu, 26 Aug 2004 17:39:24 +0200 (CEST) wrote: > > If this is true, is this local version also updated hourly with cvs update > > -d -P? > > No. > New files will only appear in the changelog after midnight. I have no problem with that. But I fear that for the lazarus directory they are never added. Can you check if the following directories exist in the local version? lazarus/ideintf lazarus/lcl/widgetset

It's now fixed. When the changelog is made, it does a CVS update first. This means also that new files will be visible at once (well, every hour).

Michael.

Reply by email

Vincent Snijders
to Unknown author
Show quoted text 12 lines
-----Oorspronkelijk bericht----- Van: [mailto:fpc-devel- Namens On Thu, 26 Aug 2004, Vincent Snijders wrote: > On Thu, 26 Aug 2004 17:39:24 +0200 (CEST) > wrote: > It's now fixed. When the changelog is made, it does a CVS update first. This means also that new files will be visible at once (well, every hour).

Thanks. It caused a big update to the ChangeLog for lazarus. :-) Revision 1.774 / (view) - annotate - [select for diffs] , Thu Aug 26 22:19:19 2004 UTC (8 hours, 8 minutes ago) by fpc
Branch: MAIN
Changes since 1.773: +1169 -1141 lines

Apparently only the Changes.lazarus was affected.

Thanks again,
Vincent.

Reply by email