Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2004-02

TProcess doesn't set environment variables correct in win32

4 messages · 3 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Vincent Snijders

Hi,

I noticed that TProcess sets the environment variables the same way on win32 as on unix systems. This is not correct.

On win32 the environment is a block of zero terminated strings terminated by a #0.

Attached is patch for process.pp, as a hint to show how this bug can be fixed.

BTW, at the moment (since last weekends changes) I can't compile the unit resolve(from the fcl) for win32.

Regards,
Vincent Snijders.

Reply by email

Unknown author
to Vincent Snijders
Vincent Snijders wrote 10 lines
Hi, I noticed that TProcess sets the environment variables the same way on win32 as on unix systems. This is not correct. On win32 the environment is a block of zero terminated strings terminated by a #0. Attached is patch for process.pp, as a hint to show how this bug can be fixed.

Seems you forgot to attach the patch?

BTW, at the moment (since last weekends changes) I can't compile the unit resolve(from the fcl) for win32.

I'll have a look at it tomorrow (read: Later today ;))

Michael.

Reply by email

Vincent Snijders
to Unknown author
Show quoted text 16 lines
On Mon, 2 Feb 2004, Vincent Snijders wrote: > Hi, > > I noticed that TProcess sets the environment variables the same way > on win32 as on unix systems. This is not correct. > > On win32 the environment is a block of zero terminated strings > terminated by a #0. > > Attached is patch for process.pp, as a hint to show how this bug can > be fixed. Seems you forgot to attach the patch?

Sorry, I sometimes mix up "include attachment" and "insert attachement" in email client. Only text files (and not gzipped files) can be inserted.

Show quoted text 5 lines
> > BTW, at the moment (since last weekends changes) I can't compile the > unit resolve(from the fcl) for win32. I'll have a look at it tomorrow (read: Later today ;))

Thanks,
Vincent.

Reply by email

Michael Van Canneyt
to Vincent Snijders
Vincent Snijders wrote 22 lines
On Tue, 3 Feb 2004 00:47:44 +0100 (CET) wrote: > > > On Mon, 2 Feb 2004, Vincent Snijders wrote: > > > Hi, > > > > I noticed that TProcess sets the environment variables the same way > > on win32 as on unix systems. This is not correct. > > > > On win32 the environment is a block of zero terminated strings > > terminated by a #0. > > > > Attached is patch for process.pp, as a hint to show how this bug can > > be fixed. > > Seems you forgot to attach the patch? Sorry, I sometimes mix up "include attachment" and "insert attachement" in email client. Only text files (and not gzipped files) can be inserted.

Applied the patch. Thanks !

I will try to split out the unix/win32 code, because it's getting wildly different now :/

Michael.

Reply by email