Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2002-05

Makefile layout

6 messages · 5 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Sergey Korshunoff

Hi!
Why Makefile's in a FPC tree have so agly layout?
For example:

ifndef ECHO
ECHO:=$(strip $(wildcard $(addsuffix /gecho$(SRCEXEEXT),$(SEARCHPATH)))) ifeq ($(ECHO),)
ECHO:=$(strip $(wildcard $(addsuffix /echo$(SRCEXEEXT),$(SEARCHPATH)))) ifeq ($(ECHO),)
ECHO=echo
else
ECHO:=$(firstword $(ECHO))
endif
else
ECHO:=$(firstword $(ECHO))
endif
endif
export ECHO

The following layout is more nicer (in my opinion): ifndef ECHO

  ECHO:=$(strip $(wildcard $(addsuffix /gecho$(SRCEXEEXT),$(SEARCHPATH))))
  ifeq ($(ECHO),)
    ECHO:=$(strip $(wildcard $(addsuffix /echo$(SRCEXEEXT),$(SEARCHPATH))))
    ifeq ($(ECHO),)
      ECHO=echo
    else
      ECHO:=$(firstword $(ECHO))
    endif
  else
    ECHO:=$(firstword $(ECHO))
  endif

endif
export ECHO

There was no problems under Linux and Windows with new layout. I change fpcmake to keep comments and spaces from Makefile.fpc and template. No problems again. And Makefile's looks much nicer.

Can you give any comments?

Regards,
Sergey Korshunoff

Reply by email

Peter Vreman
Show quoted text 40 lines
Hi! Why Makefile's in a FPC tree have so agly layout? For example: ifndef ECHO ECHO:=$(strip $(wildcard $(addsuffix /gecho$(SRCEXEEXT),$(SEARCHPATH)))) ifeq ($(ECHO),) ECHO:=$(strip $(wildcard $(addsuffix /echo$(SRCEXEEXT),$(SEARCHPATH)))) ifeq ($(ECHO),) ECHO=echo else ECHO:=$(firstword $(ECHO)) endif else ECHO:=$(firstword $(ECHO)) endif endif export ECHO The following layout is more nicer (in my opinion): ifndef ECHO ECHO:=$(strip $(wildcard $(addsuffix /gecho$(SRCEXEEXT),$(SEARCHPATH)))) ifeq ($(ECHO),) ECHO:=$(strip $(wildcard $(addsuffix /echo$(SRCEXEEXT),$(SEARCHPATH)))) ifeq ($(ECHO),) ECHO=echo else ECHO:=$(firstword $(ECHO)) endif else ECHO:=$(firstword $(ECHO)) endif endif export ECHO There was no problems under Linux and Windows with new layout. I change fpcmake to keep comments and spaces from Makefile.fpc and template. No problems again. And Makefile's looks much nicer. Can you give any comments?

I've seen some problems when the Makefile commands didn't start at the first column. Maybe it's solved with the more recenter make versions.

The Makefiles are generated files and don't need comments in the file, because the files are not meant to be edited. This saves some bytes and the size of the deltas between revisions is smaller.

Reply by email

John Merryweather Cooper
to Yuri Prokushev: Who working with EMX target?

Do you mean working on it or working with it? I work with it not on it.

Yuri Prokushev wrote 8 lines
Who working with EMX target? _______________________________________________ fpc-devel maillist - http://lists.freepascal.org/mailman/listinfo/fpc-devel
_ | |V| / ' || MacroHard -- \ \_| | | \_, || the perfection of form over | ----------------------------------|| substance, marketing over | Web: http://www.borgsdemons.com || performance, and greed over | AIM: johnmcooper || design . . . | =====================================================================/ Public Key: http://www.borgsdemons.com/Personal/pgpkey.asc | =====================================================================\

Reply by email

Unknown author
to Yuri Prokushev: Who develops emx version of fpc.

From: "Yuri Prokushev"
To:
Subject: Re: [fpc-devel]EMX
Date sent: Wed, 29 May 2002 14:56:49 -0400

Who develops emx version of fpc.

I maintain the EMX version currently. I didn't develop it, though. Is there anything I could help you with? Or do you want to help with work on this version (or the new "native" OS/2 target planned for the 1.1 branch)? Any help is most welcome, of course.

Tomas

Reply by email