Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2024-06

Freeze of fixes for 3.2.4 by 9th June

16 messages · 7 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Florian Klämpfl

To get finally forward with the 3.2.4 release, fixes will be frozen by 9th June, so if there are some last second cherry picks needed, now it’s time to speak up :)

Reply by email

Adriaan van Os
to Florian Klämpfl
Florian Klämpfl wrote
To get finally forward with the 3.2.4 release, fixes will be frozen by 9th June, so if there are some last second cherry picks needed, now it’s time to speak up :)
0038492: $setc regression;

Regards,

Adriaan van Os

Reply by email

J. Gareth Moreton
to Adriaan van Os

P.S. That's commit abf89eea0d6a36add99bfbcb6a0cedcec18cca59

Adriaan van Os wrote 15 lines
Florian Klämpfl via fpc-devel wrote: > To get finally forward with the 3.2.4 release, fixes will be frozen > by 9th June, so if there are some last second cherry picks needed, > now it’s time to speak up :) 0038492: $setc regression; Regards, Adriaan van Os _______________________________________________ fpc-devel maillist  -  https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Reply by email

Florian Klämpfl
to J. Gareth Moreton
J. Gareth Moreton wrote
P.S. That's commit abf89eea0d6a36add99bfbcb6a0cedcec18cca59

Looks like being merged already? Did you test @Adriaan?

Show quoted text 20 lines
On 03/06/2024 22:33, Adriaan van Os via fpc-devel wrote: > Florian Klämpfl via fpc-devel wrote: >> To get finally forward with the 3.2.4 release, fixes will be frozen >> by 9th June, so if there are some last second cherry picks needed, >> now it’s time to speak up :) > > 0038492: $setc regression; > > Regards, > > Adriaan van Os > > _______________________________________________ > fpc-devel maillist  -  > https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel > _______________________________________________ fpc-devel maillist  -  https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Reply by email

J. Gareth Moreton
to Florian Klämpfl: To get finally forward with the 3.2.4 release, fixes will be frozen by 9th June, so if…

Uncertain if this one has been added or not:
https://gitlab.com/freepascal.org/fpc/source/-/merge_requests/218 - this one fixes a bug with division nodes

Commits are:

54aae023ea2f4ee864c4ef3ce98ad387c166cb52 - bug fix fb14bc845943073730f66be5c0450fe08afca276 - tests

Kit

Florian Klämpfl wrote 5 lines
To get finally forward with the 3.2.4 release, fixes will be frozen by 9th June, so if there are some last second cherry picks needed, now it’s time to speak up :) _______________________________________________ fpc-devel maillist - https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Reply by email

Martin Frb
to Martin Frb
Martin Frb wrote 7 lines
On 02/06/2024 22:28, Florian Klämpfl via fpc-devel wrote: > To get finally forward with the 3.2.4 release, fixes will be frozen > by 9th June, so if there are some last second cherry picks needed, > now it’s time to speak up :) Has the line info field for Dwarf 4 been merged? https://lists.freepascal.org/pipermail/fpc-devel/2024-May/045658.html

Got the commit: b313a66a47822b0648e25f49ee60ec1719d1443e *   * correct Dwarf-4 line info header as noted by Martin on the mailing list

Reply by email

J. Gareth Moreton
to Marģers .

If you've got the commit(s) to hand, there's still time!

Kit

Marģers . wrote 11 lines
Is there a reason why missing x86 assembler instructions have not made to fixes (except for avx512, that would be too much)? To get finally forward with the 3.2.4 release, fixes will be frozen by 9th June, so if there are some last second cherry picks needed, now it’s time to speak up :) _______________________________________________ fpc-devel maillist https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
This email has been checked for viruses by Avast antivirus software. www.avast.com

Reply by email

J. Gareth Moreton
to Marģers .

Yeah, unfortunately that sounds risky and untested.

Kit

Marģers . wrote 42 lines
If you put it that way, then no, i don't I'm not sure there exists nice commits to pick from. There was a big avx512 branch merge. I made patch for personal use by comparing x86ins.dat from fixes and main. Striped all avx512 lines and avx512 only instructions. What was left was missing instructions. Copy - paste, some manual changes and good to go. https://lists.freepascal.org/pipermail/fpc-devel/2024-May/045670.html i guess that kind approach is not welcomed *From:* J. Gareth Moreton via fpc-devel < > *To:* < > If you've got the commit(s) to hand, there's still time! Kit On 08/06/2024 14:00, Marģers . via fpc-devel wrote: Is there a reason why missing x86 assembler instructions have not made to fixes (except for avx512, that would be too much)? To get finally forward with the 3.2.4 release, fixes will be frozen by 9th June, so if there are some last second cherry picks needed, now it’s time to speak up :) _______________________________________________ fpc-devel maillist https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient> Virus-free.www.avast.com <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient> _______________________________________________ fpc-devel maillist https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
This email has been checked for viruses by Avast antivirus software. www.avast.com

Reply by email

Benito van der Zander
to Florian Klämpfl: To get finally forward with the 3.2.4 release, fixes will be frozen by 9th June, so if…

Hi,

i made two patches to fix my Android app crashing:

https://gitlab.com/freepascal.org/fpc/source/-/merge_requests/235

https://gitlab.com/freepascal.org/fpc/source/-/issues/39985

I do not believe it is possible to build a stable Android 64-bit library with current fixes

Cheers,
Benito

Florian Klämpfl wrote
To get finally forward with the 3.2.4 release, fixes will be frozen by 9th June, so if there are some last second cherry picks needed, now it’s time to speak up :) _______________________________________________ fpc-devel maillist https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Reply by email

Florian Klämpfl
to Martin Frb: Got the commit: b313a66a47822b0648e25f49ee60ec1719d1443e *   * correct Dwarf-4 line…
Martin Frb wrote 12 lines
On 06/06/2024 16:50, Martin Frb via fpc-devel wrote: > On 02/06/2024 22:28, Florian Klämpfl via fpc-devel wrote: >> To get finally forward with the 3.2.4 release, fixes will be frozen >> by 9th June, so if there are some last second cherry picks needed, >> now it’s time to speak up :) > > Has the line info field for Dwarf 4 been merged? > https://lists.freepascal.org/pipermail/fpc-devel/2024-May/045658.html Got the commit: b313a66a47822b0648e25f49ee60ec1719d1443e *   * correct Dwarf-4 line info header as noted by Martin on the mailing list

Merged.

Reply by email

Florian Klämpfl
to J. Gareth Moreton: Uncertain if this one has been added or not: https://gitlab.com/freepascal.org/fpc/source/…
J. Gareth Moreton wrote 8 lines
Uncertain if this one has been added or not: https://gitlab.com/freepascal.org/fpc/source/-/merge_requests/218 - this one fixes a bug with division nodes Commits are: 54aae023ea2f4ee864c4ef3ce98ad387c166cb52 - bug fix fb14bc845943073730f66be5c0450fe08afca276 - tests

The bug is not in 3.2.3. I merged the test for safety.

Show quoted text 14 lines
Kit On 02/06/2024 21:28, Florian Klämpfl via fpc-devel wrote: > To get finally forward with the 3.2.4 release, fixes will be frozen by > 9th June, so if there are some last second cherry picks needed, now > it’s time to speak up :) > _______________________________________________ > fpc-devel maillist  -  > https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel > _______________________________________________ fpc-devel maillist  -  https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Reply by email

J. Gareth Moreton
to Florian Klämpfl

Aah, that's fair.  I thought I had finalised the reciprocal multiplication algorithms earlier than that.

Apologies for not putting together a test for the other commit. I've been tied up with other tasks.  I'll still try to put one together though if you would still like an extra test case.

Kit

Florian Klämpfl wrote 31 lines
On 05.06.24 13:16, J. Gareth Moreton via fpc-devel wrote: > Uncertain if this one has been added or not: > https://gitlab.com/freepascal.org/fpc/source/-/merge_requests/218 - > this one fixes a bug with division nodes > > Commits are: > > 54aae023ea2f4ee864c4ef3ce98ad387c166cb52 - bug fix > fb14bc845943073730f66be5c0450fe08afca276 - tests The bug is not in 3.2.3. I merged the test for safety. > > Kit > > On 02/06/2024 21:28, Florian Klämpfl via fpc-devel wrote: >> To get finally forward with the 3.2.4 release, fixes will be frozen >> by 9th June, so if there are some last second cherry picks needed, >> now it’s time to speak up :) >> _______________________________________________ >> fpc-devel maillist  -  >> https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel >> > _______________________________________________ > fpc-devel maillist  -  > https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel _______________________________________________ fpc-devel maillist  -  https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
This email has been checked for viruses by Avast antivirus software. www.avast.com

Reply by email