Hi everyone,

I just need to double-check something.  Under CPU16, SizeInt and SizeUInt are declared as follows:

   SizeInt = Integer;
   SizeUInt = Word;

Is Integer 16-bit in this case? I always thought Integer was defined as a signed 32-bit integer under FreePascal.  Or is this a bug with rtl/inc/systemh.inc and it should be defined as SmallInt instead?

Kit

Yes.

I always thought Integer was defined as a signed 32-bit integer under FreePascal.

No. Only in objfpc/delphi modes, and system is in $mode FPC. Unit objpas overrides this definition and is loaded in objfpc/delphi mode.

begin
writeln(sizeof(integer));
end.

without any $mode (so $mode fpc) will write 2, even on 64-bit systems.

On 2022-11-24 14:13, J. Gareth Moreton via fpc-devel wrote:

Hi Kit,

You're wrong. The size of Integer depends on the compilation mode. It is 16-bit in the TP and FPC modes, but overridden to 32-bit in OBJPAS and DELPHI modes.

Tomas

Are you sure? systemh.inc is compiled with {$mode objfpc} (see line 22), so Integer within the system unit is 32-bit.

So to me it looks like a bug.

Documentation:
https://www.freepascal.org/docs-html/ref/refsu4.html https://www.freepascal.org/docs-html/rtl/system/sizeint.html

Ondrej

OK, I found it. Actually within the system unit Integer is always 16-bit because it is re-declared on line 114:
Integer  = SmallInt;

So yes, Integer in the system unit is 16-bit but because of the re-declaration and not the mode.

Ondrej

Hence why I wanted to double-check!  Normally if I want something to be an particular size, I use "ShortInt", "SmallInt" and "LongInt" etc. to ensure there is no ambiguity.

Kit

1. Then why does the posted code print 2?

2. using {$mode objfpc in the system unit can't load objpas that overrides the integer, even if the mode is set.

Indeed, it seems to me that this directive should be removed from the system unit.

OTOH, it's probably needed to enable classes for the TObject definition ?

Maybe the compiler contains some code to detect this special case.

Michael.

No, it isn't a bug - systemh.inc is indeed compiled in $MODE OBJFPC nowadays, but it defines Integer = SmallInt on line 110. Depending on compilation mode used for your sources (containing references to Integer), the definition in unit objpas (included automatically for modes objfpc and delphi) may override the definition in systemh.inc.

Tomas

All clear now. Thanks!

Ondrej

Would it be better to define "SizeInt = SmallInt;" here just so it's crystal clear what size it is?

Kit

J. Gareth Moreton wrote

Would it be better to define "SizeInt = SmallInt;" here just so it's crystal clear what size it is?

Where is 'here' ?

Michael.

rtl/inc/systemh.inc, line 360

Beg your pardon, it's line 451.  I was looking at the version of the file in FPC 3.2.0, not the trunk.

Kit

J. Gareth Moreton wrote

rtl/inc/systemh.inc, line 360

Latest Git says:

{$ifdef CPURISCV64}
   {$define DEFAULT_DOUBLE}
   {$define FPC_INCLUDE_SOFTWARE_MOD_DIV}
   {$define FPC_INCLUDE_SOFTWARE_MUL}
   {$define FPC_INCLUDE_SOFTWARE_INT64_TO_DOUBLE}
   {$ifndef FPUNONE}
     {$define SUPPORT_SINGLE}
     {$define SUPPORT_DOUBLE}
     {$define FPC_INCLUDE_SOFTWARE_INT64_TO_DOUBLE}
// <----- Line 360
     ValReal = Double;
   {$endif}
{$endif CPURISCV64}

So I think the line you mean is 451 in latest git.

But yes, it is probably better to say

SizeInt = SmallInt;

Michael.

Michael Van Canneyt wrote

SizeInt = SmallInt;

(IMHO get rid of small and short in general, and simply put int8/16 instead. But that might require compiler work?)

Agreed.

I would also prefer the use of int8/uint8/int16/uint16 etc. as the basic compiler types, but those will indeed need some compiler work, which is why I didn't propose it.

If they appear, at that point we can define Small/Short/LongInt simply as aliases. It would be much more clear.

Michael.