Hi,

After revision 43841 make all in the root fails:

make[3]: Leaving directory `C:/devel/fpc/trunk/rtl' make -C fpmkunit bootstrap FPC=C:/devel/fpc/trunk/compiler/ppc386.exe make[3]: Entering directory `C:/devel/fpc/trunk/packages/fpmkunit' C:/devel/fpc/3.0.4/bin/i386-Win32/gmkdir.exe -p units_bs/i386-win32 C:/devel/fpc/trunk/compiler/ppc386.exe src/fpmkunit.pp -FuC:/devel/fpc/trunk/rtl/units/i386-win32 -FUunits_bs/i386-win32 -Fu../paszlib/src -Fu../hash/src -Fi../paszlib/src -Fi../fcl-process/src/win -Fu../fcl-process/src
-Fi../fcl-process/src/win32 -Fi../fcl-process/src/dummy -Fu../libtar/src -g -gl
fpmkunit.pp(4850,16) Error: Incompatible types: got "TStrings" expected "TStringsOptions"
fpmkunit.pp(9524) Fatal: There were 1 errors compiling module, stopping

Bart wrote

After revision 43841 make all in the root fails

Thanks - I fixed this one. But there seems to be another problem. I am on it now.

Ondrej

PM Bart wrote

fpmkunit.pp(4850,16) Error: Incompatible types: got "TStrings" expected "TStringsOptions" fpmkunit.pp(9524) Fatal: There were 1 errors compiling module, stopping

If I fix that
( on line 4850 change

  Options:=OptionsToStringList(Values[KeyOptions]);

into

  Self.Options:=OptionsToStringList(Values[KeyOptions]);

)

I get the following crash:

make[3]: Leaving directory `C:/devel/fpc/trunk/packages/fpmkunit' C:/devel/fpc/trunk/compiler/ppc386.exe fpmake.pp
-FuC:/devel/fpc/trunk/packages/fpmkunit/units_bs/i386-win32 -FuC:/devel/fpc/trunk/rtl/units/i386-win32 -g -gl ./fpmake.exe compile --localunitdir=.. --os=win32 --cpu=i386 -o -Ur -o -Xs -o -O2 -o -n -o -g -o -gl -o -di386 -o -dRELEASE --compiler=C:/devel/fpc/trunk/compiler/ppc386.exe -bu -o -XX -o -CX The installer encountered the following error:
Access violation
An unhandled exception occurred at $65006E2D:
EAccessViolation: Access violation
$65006E2D
$00455589 FINALIZEUNITS, line 1065 of C:/devel/fpc/trunk/rtl/inc/system.inc $004950F1 INSTALLER, line 9461 of src/fpmkunit.pp $00401932 ADD_A52, line 3 of fpmake_proc.inc
$00449A38 ADD_PACKAGES, line 1 of fpmake_add.inc $0044B423 main, line 50 of fpmake.pp

An unhandled exception occurred at $65006E2D:
EAccessViolation: Access violation
$65006E2D
$004645CA TENCODING__destroy, line 215 of
C:/devel/fpc/trunk/rtl/objpas/sysutils/sysencoding.inc $00455589 FINALIZEUNITS, line 1065 of C:/devel/fpc/trunk/rtl/inc/system.inc $77AB8DA2
$77AB8D74
$77AA4216
$00455589 FINALIZEUNITS, line 1065 of C:/devel/fpc/trunk/rtl/inc/system.inc $004950F1 INSTALLER, line 9461 of src/fpmkunit.pp $00401932 ADD_A52, line 3 of fpmake_proc.inc
$00449A38 ADD_PACKAGES, line 1 of fpmake_add.inc $0044B423 main, line 50 of fpmake.pp

make[2]: *** [smart] Error 217
make[2]: Leaving directory `C:/devel/fpc/trunk/packages' make[1]: *** [packages_smart] Error 2
make[1]: Leaving directory `C:/devel/fpc/trunk'
make: *** [build-stamp.i386-win32] Error 2

PM Ondrej Pokorny wrote

Thanks - I fixed this one. But there seems to be another problem. I am on it now.

Yeah, saw that too ...

It should be fixed with r43846. You may need to delete fpmake.exe and fpmake.o to make sure they are recompiled.

Ondrej

PM Ondrej Pokorny wrote

It should be fixed with r43846.

Yes, thanks.

You may need to delete fpmake.exe and fpmake.o to make sure they are recompiled.

Yes, it failed before that.
Good thing you wrote it here.

Isn't make clean or make distclean supposed to take care of that? (Neither of them do)

Bart via fpc-devel schrieb am Fr., 3. Jan.
2020, 02:26:

I think if you call "make clean" or "make distclean" a second time the fpmake binaries will be cleaned up as well.

Regards,
Sven

AM Sven Barth wrote

> Isn't make clean or make distclean supposed to take care of that? > (Neither of them do) I think if you call "make clean" or "make distclean" a second time the fpmake binaries will be cleaned up as well.

No, it doesn't (that is: it didn't for me).
I ran make clean twice
Then I ran make distclean.

It seems that make distclean invokes fpmake... (which then crashed).

Bart