Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2019-10

multi-line strings

7 messages · 5 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Ryan Joseph
to Marģers .

I can’t remember what Bens patch did using compiler directives but I like the Java idea of using the column of the opening string character as the reference point for indentation. Seems easier.

Did the FPC team even approve this idea yet? It’s such a simple patch but I fear it’s going to be waiting in limbo for up to 12 months.

Show quoted text 12 lines
On Oct 5, 2019, at 10:53 AM, Marģers . via fpc-devel wrote: hi, Java is going to have multi-line strings https://www.youtube.com/watch?v=J1YKAFtNz70 I'm posting this, because they have different way of indentation as its currently in proposed patch. Maybe it worth of consideration. If not, it's ok. _______________________________________________ fpc-devel maillist - https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Regards,
Ryan Joseph

Ben Grasset
to Ryan Joseph
PM Ryan Joseph wrote 7 lines
I can’t remember what Bens patch did using compiler directives but I like the Java idea of using the column of the opening string character as the reference point for indentation. Seems easier. Did the FPC team even approve this idea yet? It’s such a simple patch but I fear it’s going to be waiting in limbo for up to 12 months.

My patch does support exactly that, if you use {$MultiLineStringTrimLeft Auto}.

As far as "approval", if I recall correctly Sven said he intended to review it eventually.

Michael Van Canneyt
to Ben Grasset
Ben Grasset wrote 15 lines
On Sat, Oct 5, 2019 at 1:37 PM Ryan Joseph wrote: > I can’t remember what Bens patch did using compiler directives but I like > the Java idea of using the column of the opening string character as the > reference point for indentation. Seems easier. > > Did the FPC team even approve this idea yet? It’s such a simple patch but > I fear it’s going to be waiting in limbo for up to 12 months. > My patch does support exactly that, if you use {$MultiLineStringTrimLeft Auto}. As far as "approval", if I recall correctly Sven said he intended to review it eventually.

I remember the same.

Michael.

Sven Barth
to Michael Van Canneyt: I remember the same. Michael.

Michael Van Canneyt schrieb am Mo., 7. Okt. 2019, 17:21:

Show quoted text 25 lines
On Mon, 7 Oct 2019, Ben Grasset wrote: > On Sat, Oct 5, 2019 at 1:37 PM Ryan Joseph wrote: > >> I can’t remember what Bens patch did using compiler directives but I like >> the Java idea of using the column of the opening string character as the >> reference point for indentation. Seems easier. >> >> Did the FPC team even approve this idea yet? It’s such a simple patch but >> I fear it’s going to be waiting in limbo for up to 12 months. >> > > My patch does support exactly that, if you use {$MultiLineStringTrimLeft > Auto}. > > As far as "approval", if I recall correctly Sven said he intended to review > it eventually. I remember the same.

The code changes themselves are okay and that was all I promised to review. The problem is I personally don't care about the feature, so other core devs should give their okay for the feature itself as well. If I get that okay I'll integrate it, no problem...

Regards,
Sven

Ben Grasset
to Sven Barth

On Mon, Oct 7, 2019 at 1:51 PM Sven Barth via fpc-devel <

Show quoted text 7 lines
wrote: The code changes themselves are okay and that was all I promised to review. The problem is I personally don't care about the feature, so other core devs should give their okay for the feature itself as well. If I get that okay I'll integrate it, no problem...

Makes sense. I'll upload a fresh copy of the patch files later today just to make sure it's ready to go for whenever, as I think there were a few changes to at least "scanner.pas" made in trunk recently that could possibly cause the current files not to work.