Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2019-05

Re: [Core] Haiku merges: Revision 42117

2 messages · 2 people ·

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Pierre Muller

The merge of the two commits generate 3 conflicts, but those are easily solved. See attached patch.

Olivier, did you test the fixes_3_2 branch?
Do you think it is reasonable to enable x86_64-haiku target in that branch?

charlie, you wrote those patches, thus
it is probably best if you or Olivier decide:
Should I merge them?

Pierre

Le 26/05/2019 à 15:17, Pierre Muller a écrit :

Show quoted text 47 lines
Hi al, almost every haiku RTL changes have been merged, but there are also two compiler changes: pas]$ svn log -v -c 40753 trunk/fpcsrc/ ------------------------------------------------------------------------ r40753 | karoly | 2019-01-04 02:16:24 +0000 (Fri, 04 Jan 2019) | 1 line Changed paths: M /trunk/compiler/options.pas M /trunk/compiler/systems/i_haiku.pas M /trunk/compiler/systems/t_haiku.pas M /trunk/compiler/systems.inc M /trunk/compiler/utils/ppuutils/ppudump.pp M /trunk/compiler/x86/agx86att.pas M /trunk/compiler/x86_64/cpuelf.pas M /trunk/compiler/x86_64/cputarg.pas M /trunk/packages/fpmkunit/src/fpmkunit.pp M /trunk/utils/fpcm/fpcmmain.pp haiku-x86_64: add target to the compiler and ppudump, enable it in fpmake and fpcmake ------------------------------------------------------------------------ pas]$ svn log -v -c 40756 trunk/fpcsrc/ ------------------------------------------------------------------------ r40756 | karoly | 2019-01-04 03:00:03 +0000 (Fri, 04 Jan 2019) | 1 line Changed paths: M /trunk/compiler/systems/t_haiku.pas M /trunk/compiler/systems.pas haiku: linker support code for internal sysinit and make the x86_64 port use it ------------------------------------------------------------------------ Shoudln't these two be also merged to fixes? Pierre <https://svn.freepascal.org/cgi-bin/viewvc.cgi?root=fpc&view=rev&rev=42117> _______________________________________________ core site list https://idefix.freepascal.org/cgi-bin/mailman/listinfo/core

Reply by email

Karoly Balogh (Charlie/SGR
to Pierre Muller

Hi,

Pierre Muller wrote 5 lines
The merge of the two commits generate 3 conflicts, but those are easily solved. See attached patch. Olivier, did you test the fixes_3_2 branch? Do you think it is reasonable to enable x86_64-haiku target in that branch?

I think if all the changes are merged, it's safe to enable at least, but it needs to be tested of course. I only tested trunk.

charlie, you wrote those patches, thus it is probably best if you or Olivier decide: Should I merge them?

I think they should be merged, but Olivier is the maintainer. But as the RTL changes are merged already (Marco did it after asking me), I think the associated compiler changes should be merged too.

I'm unaware of any Haiku regressions compared to before my changes, OTOH after my changes the entire thing is much cleaner and of course supports x86_64 as well. If anyone is aware of any regression, I'm gladly fixing them ASAP both in trunk and then it can be merged to 3.2 as well.

Charlie

Reply by email