Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2019-02

commits for merging to 3.2 ?

5 messages · 3 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Sven Barth
to Marco van de Voort

Am Mo., 11. Feb. 2019, 10:07 hat Marco van de Voort <

Show quoted text 16 lines
geschrieben: Op 2/10/2019 om 9:47 PM schreef Martin: > I am not sure if there is a place for the indent to merge (or absent > thereof) can be checked? > > Once merged, the svn log, but before? Will the target on mantis > always indicate the decision made? > > Can the following 2 be merged? > https://bugs.freepascal.org/view.php?id=35027 > https://bugs.freepascal.org/view.php?id=35028 > If Sven says to merge them, I will.

If the testsuite isn't saying otherwise you have a green light for that (I'd first need to check today's Changed results :/ ).

Regards,
Sven

Reply by email

Marco van de Voort
to Sven Barth

Op 2/11/2019 om 2:38 PM schreef Sven Barth via fpc-devel:

Show quoted text 6 lines
If Sven says to merge them, I will. If the testsuite isn't saying otherwise you have a green light for that (I'd first need to check today's Changed results :/ ).

The only regression is the new test added. I suspect because it has the lazarus cthreads clause

{$IFDEF UseCThreads} cthreads, {$ENDIF}

in the uses list, but probably the text runner doesn't enable that define?

Reply by email

Sven Barth
to Marco van de Voort

Am Mo., 11. Feb. 2019, 15:13 hat Marco van de Voort <

Show quoted text 21 lines
geschrieben: Op 2/11/2019 om 2:38 PM schreef Sven Barth via fpc-devel: If Sven says to merge them, I will. > If the testsuite isn't saying otherwise you have a green light for that (I'd first need to check today's Changed results :/ ). The only regression is the new test added. I suspect because it has the lazarus cthreads clause {$IFDEF UseCThreads} cthreads, {$ENDIF} in the uses list, but probably the text runner doesn't enable that define?

Ah, dang it. In the other test I had changed that to Unix but in that one I forgot it 😑 I'll correct that shortly.

Regards,
Sven

Reply by email