Hi,

I'm trying to fix an issue in getopts unit.
I noticed some (ancient?) compiler directives:

{$IFNDEF FPC}
  {$ifdef TP}
    uses strings;
  {$else }
    uses SysUtils;
    type PtrInt = Integer;
  {$endif}
{$ENDIF FPC}
{$IF not Declared(argv)} //{$ifdef TP}
type
  ppchar = ^pchar;
  apchar = array[0..127] of pchar;
var
  argc  : longint;
  argv  : apchar;
....
{ create argv if running under TP }
{$ifndef FPC}
  setup_arguments;
{$endif}

It seems this code at one time needed to be compilable with TP. AFAIK TP however does not support {$IF CONDITION} nor the Declared() macro(?), so the source should not be compilable anymore with TP?

The unit is still compileable with Delphi (7) though.

Question is: do we need to keep that in?
I don't think it is possible anymore to bootstrap the compiler with anything other than FPC?

As for the {$IF not Declared(Argv)} part: does that apply to a target that FPC supports or is also there just to be able to compile it with Delphi?

If we keep it, then at least the comments should be updated.

Bart

Bart wrote

It seems this code at one time needed to be compilable with TP. AFAIK TP however does not support {$IF CONDITION} nor the Declared() macro(?), so the source should not be compilable anymore with TP?

if we set TP mode, what will happens if $IF is removed/changed?

i still have a lot of TP code here and some of it has been ported to FPC... some of that ported code has been recoded to use getopts which allow a lot of other code to be stripped out because getopts handles command line options much better...

At the very least, compiling under Turbo Pascal for historic reasons. Unless I'm mistaken, the very first versions of Free Pascal were written in Turbo Pascal 7.0 because Borland announced it would not make a compiler for 32-bit processors (having moved their focus to their little-known, upcoming Windows project known as Delphi).  Development under Turbo Pascal ceased once the compiler was able to compile itself.

Gareth aka. Kit

Bart wrote

It seems this code at one time needed to be compilable with TP. AFAIK TP however does not support {$IF CONDITION} nor the Declared() macro(?), so the source should not be compilable anymore with TP?

if we set TP mode, what will happens if $IF is removed/changed?

i still have a lot of TP code here and some of it has been ported to FPC... some
of that ported code has been recoded to use getopts which allow a lot of other
code to be stripped out because getopts handles command line options much better...

Am 17.01.2019 um 20:29 schrieb

Even if you set TP mode in your own unit that won't change the mode of the getopts unit. FPC can use units with different modes without any problems.

Also scanning condition expressions is nearly completely independant of the mode (one of the only exceptions is support for special MacPas directives in MacPas mode).

Regards,
Sven

Clearly not.

The unit is still compileable with Delphi (7) though. Question is: do we need to keep that in?

No.

I don't think it is possible anymore to bootstrap the compiler with anything other than FPC?

Exactly.

You can make the unit FPC only if you wish.

Michael.

I just checked the logs: the unit had been explicitely made Delphi compatible by adding the check for argv. So maybe we shouldn't just throw that one out of the window... (TP compatibility is a different topic)

Regards,
Sven

If support for delphi can be reduced to an IFDEF FPC with the ELSE for Delphi (or vice versa) in one or 2 places I'm inclined to agree...
But if it needs much more than that I am not really in favour...

Michael.