Hi,

In FPC 3.0.0 and TRUNK for Windows:

SysUtils.GetEnvironmentVariable(String) uses GetEnvironmentVariableA SysUtils.GetEnvironmentVariable(UnicodeString) uses GetEnvironmentStringsW

GetEnvironmentVariableA produces a result crippled by ANSI/OEM. Can it be replaced with a simple typecast of UnicodeString based function:

function GetEnvironmentVariable(const EnvVar: String): String;
begin
  Result := String(GetEnvironmentVariable(UnicodeString(EnvVar)));
end;

Denis

P.S. A minor typo, GetEnvironmentVariableA should read GetEnvironmentStringsA.

The typecase will not help you, since the result is an ansistring. The result will still be crippled.

The only solution for this is a unicode RTL.

Michael.

Michael Van Canneyt wrote on Mon, 23 May 2016:

The typecase will not help you, since the result is an ansistring. The result will still be crippled.

It would help when DefaultSystemCodePage is changed to UTF-8, as Lazarus does.

The only solution for this is a unicode RTL.

That is incorrect, since as he wrote the unicodestring version of GetEnvironmentVariable() already exists in our RTL today. It's just that it's only used if you pass it a unicodestring argument, which won't be be the case in most Lazarus programs by default.

Jonas

Should that not be multibytecodepage or so ?

Aha. I didn't know we already had an overloaded version. I stand corrected !

Michael.

Michael Van Canneyt wrote on Mon, 23 May 2016:

The proper way to change DefaultSystemCodePage is by calling SetMultiByteConversionCodePage(), yes.

Jonas

So, do we agree that it would be beneficial to change SysUtils.GetEnvironmentVariable(String) to call the UnicodeString overload internally?

function GetEnvironmentVariable(const EnvVar: String): String;
begin
  Result := String(GetEnvironmentVariable(UnicodeString(EnvVar)));
end;

This would propagate to GetEnvironmentVariableUTF8 in Lazarus, where a ConsoleToUTF8 conversion should then be removed.

SysUtils.GetEnvironmentString(Integer) and
SysUtils.GetEnvironmentVariableCount() also call crippled GetEnvironmentStringsA.

Denis