I am not sure if this is a problem of the Generics.Collections unit I am using (https://github.com/dathox/generics.collections) as this unit is always compiled with -Mdelphi or if this is an issue with fpc's parser.

The following snippet compiles fine in delphi mode, but does not compile in ObjectFPC Mode:

type
   TSpecialFunctionBits = record
     name: String;
     Position: longWord;
     Mask: longWord;
     notMask: longWord;
     Length: longWord;
     constructor create(theName: String; thePosition, theMask,
theLength: longWord);
   end;

Error is:

Fatal: Syntax error, ";" expected but "<" found

I saw this error with trunk fpc.

Michael

Are you sure that's the correct location? I don't see a "<" anywhere there. Can it be that you are missing a "specialize" where you're specializing the generic? Also note that ObjFPC does not support inline specializations (yet), specializations must be done in "type" sections.

Regards,
Sven

Argh, soory, cut & waste error, this is the correct thing:

   TSpecialFunctionRegister = record
     name: String;
     device: String;
     address: longWord;
     bits: TList<TSpecialFunctionBits>;
     constructor create(theName: String; theAddress: longWord);
   end;

As I expected. Try this:

=== code begin ===

TSpecialFunctionRegister = record
public type
   TSpecialFunctionBitsList = specialize TList<TSpecialFunctionBits>
   // alternatively you could declare that outside of the record as well
if you need it more often
public
   name: String;
   device: String;
   address: LongWord;
   bits: TSpecialFunctionBitsList;
   constructor Create(theName: String; theAddress: LongWord);
end;

=== code end ===

Regards,
Sven

Did not work, now I get

Fatal: Syntax error, ";" expected but "identifier PUBLIC" found

I did a cut & paste of your code into my code

Michael

Do you have {$modeswitch advancedrecords} enabled? I thought you already have that, because of the "constructor" (without that modeswitch constructors/methods wouldn't work either).

Regards,
Sven

Maybe try adding a semi-colon at the location marked below.

There's a missing ; after the specialization

I now officially feel stupid, this now works with the ; in place, I could have sworn that I have tried this......

But two lines deeper I end up with a new problem now:

   TSpecialFunctionRegisterComparer =
class(TComparer<TSpecialFunctionRegister>)
     function Compare(constref Left, Right: TSpecialFunctionRegister):
Integer; override;
   end;

Error: class type expected, but got "TComparer"
Fatal: class type expected, but got "TComparer"

Is this a similar problem?

If yes then I guess I will need to stay with -Mdelphi the specialize syntax is not availabe in delphi mode (identifier not found "specialize") and the generics library where TComparer comes from explicitly sets delphi mode.

Michael

"Michael Ring" wrote

I now officially feel stupid, this now works with the ; in place, I could

have sworn that I have tried this......

But two lines deeper I end up with a new problem now: TSpecialFunctionRegisterComparer =

class(TComparer<TSpecialFunctionRegister>)

function Compare(constref Left, Right: TSpecialFunctionRegister):

Integer; override;

syntax is not availabe in delphi mode (identifier not found "specialize") and the generics library where TComparer comes from explicitly sets delphi mode.

In mode ObjFPC you must use "specialize" when you want to specialize a class, this includes the declaration of the class parent. Also mixing generics from different modes makes no difference, the compiler supports that.

Regards,
Sven

"Jeppe Johansen" wrote

There's a missing ; after the specialization

Sorry about that... I just typed that in the mail client...

Regards,
Sven