Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2011-09

TField.Validate in FPC 2.6

7 messages · 6 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Martin Schreiber

Hi,
TField.SetData() in fixes_2_6 calls TField.Validate(). 2.4.4 does not, trunk neither.
What are the plans for the upcoming release? Will FPC 2.6.0 call TField.Validate() in TField.SetData()?

Martin

Reply by email

Michael Van Canneyt
to Martin Schreiber
Martin Schreiber wrote
Hi, TField.SetData() in fixes_2_6 calls TField.Validate(). 2.4.4 does not, trunk neither.

Strange that 2.6 does this if trunk does not ?

What are the plans for the upcoming release? Will FPC 2.6.0 call TField.Validate() in TField.SetData()?

It should not.

Michael.
yy

Reply by email

Joost van der Sluis
to Michael Van Canneyt
Michael Van Canneyt wrote 13 lines
On Sat, 17 Sep 2011, Martin Schreiber wrote: > Hi, > TField.SetData() in fixes_2_6 calls TField.Validate(). > 2.4.4 does not, trunk neither. Strange that 2.6 does this if trunk does not ? > What are the plans for the upcoming release? Will FPC 2.6.0 call > TField.Validate() in TField.SetData()? It should not.

There were some changes regarding this, and I still didn't will and decide how to solve this. (I think I'll revert it all)

Joost.

Reply by email

Marco van de Voort
to Martin Schreiber: TField.SetData() in fixes_2_6 calls TField.Validate(). 2.4.4 does not, trunk neither.…

In our previous episode, Martin Schreiber said:

TField.SetData() in fixes_2_6 calls TField.Validate(). 2.4.4 does not, trunk neither. What are the plans for the upcoming release? Will FPC 2.6.0 call TField.Validate() in TField.SetData()?

It's on the list to be merged:

http://www.stack.nl/~marcov/mergelogs26/

group "database" the third or fourth commit. I'm planning to merge of my commits there in time, unless I get signals something is wrong with it.

Actually, that might have been merged this weekend anyway, since with over two weeks no comments it is sufficiently old.

For Michael's commits (mostly the new export stuff), I'm waiting for his confirmation that it can be merged.

Reply by email

LacaK
to Joost van der Sluis: There were some changes regarding this, and I still didn't will and decide how to solve…

Joost van der Sluis wrote / napísal(a):

Show quoted text 21 lines
On Sat, 2011-09-17 at 10:56 +0200, Michael Van Canneyt wrote: > On Sat, 17 Sep 2011, Martin Schreiber wrote: > > >> Hi, >> TField.SetData() in fixes_2_6 calls TField.Validate(). >> 2.4.4 does not, trunk neither. >> > Strange that 2.6 does this if trunk does not ? > > >> What are the plans for the upcoming release? Will FPC 2.6.0 call >> TField.Validate() in TField.SetData()? >> > It should not. > There were some changes regarding this, and I still didn't look at them. I will and decide how to solve this. (I think I'll revert it all)

Please look at
http://svn.freepascal.org/cgi-bin/viewvc.cgi?view=rev&revision=18872 This commit (patch by Luiz Americo) is OK.
It was a long time awaited feature, so please do not drop it. Thanks
-Laco.

Reply by email

Martin Schreiber
to Joost van der Sluis: There were some changes regarding this, and I still didn't will and decide how to solve…
Joost van der Sluis wrote 18 lines
On Sat, 2011-09-17 at 10:56 +0200, Michael Van Canneyt wrote: > > On Sat, 17 Sep 2011, Martin Schreiber wrote: > >> Hi, >> TField.SetData() in fixes_2_6 calls TField.Validate(). >> 2.4.4 does not, trunk neither. > > Strange that 2.6 does this if trunk does not ? > >> What are the plans for the upcoming release? Will FPC 2.6.0 call >> TField.Validate() in TField.SetData()? > > It should not. There were some changes regarding this, and I still didn't look at them. I will and decide how to solve this. (I think I'll revert it all)

Has a decision been made already? I should know if I must implement workarounds into MSEgui.

Thanks, Martin

Reply by email

Luiz Americo Pereira Camara
to Martin Schreiber
Martin Schreiber wrote 7 lines
Am 17.09.2011 10:18, schrieb Joost van der Sluis: > > There were some changes regarding this, and I still didn't look at them. > I will and decide how to solve this. (I think I'll revert it all) > Has a decision been made already? I should know if I must implement workarounds into MSEgui.

The fix was already committed to trunk. See
http://svn.freepascal.org/cgi-bin/viewvc.cgi?view=rev&revision=18872

Marco will merge into fpc26

Luiz

Reply by email