Hi,
it seems, that there is ATM no versions of StrCopy, StrLCopy, which works with WideChars (in SysUtils).
Can these variants be added ?

function StrCopy(Dest: PWideChar; const Source: PWideChar): PWideChar;
http://docwiki.embarcadero.com/VCL/en/SysUtils.StrCopy
function StrLCopy(Dest: PWideChar; const Source: PWideChar; MaxLen: Cardinal): PWideChar;
http://docwiki.embarcadero.com/VCL/en/SysUtils.StrLCopy

etc.

Or do you not like these "wide" versions at all ?

TIA
-Laco.

It's not a matter of liking, I'm afraid.
If Delphi has them, we'll have to add them too :-)

Can you please add an entry in the bug tracker, so we don't forget ?

Michael.

Michael Van Canneyt wrote / napísal(a):

http://bugs.freepascal.org/view.php?id=19989
Do you think, that it is realistic expect them in 1-2 months ? Thanks
-Laco.

Not unless someone donates a patch.

Michael.

Supply an patch, to speed up the implementation.

But first the Delphi implementations should be explored, since the following looks not okay to me:

"StrLCopy copies a maximum MaxLen characters from Source to Dest, then adds a null terminator to Dest and returns Dest. The SizeOf standard function (Delphi) or the sizeof operator (C++) can be used to determine the MaxLen parameter. Usually, MaxLen equals SizeOf(Dest)-1."

The mix (or equivalence) of character and byte counts obviously is inappropriate for "wide" versions. Perhaps "sizeof" should read "Length"?

DoDi

Hans-Peter Diettrich wrote / napísal(a):

Ok, I can try prepare patch, but only "generic" i.e. which uses only Pascal. Processor specific implementations (which use assembler, like it is done for AnsiString versions) I am afraid is too dificult for me ATM ;-) And also decision where to put (in which units) these functions I will leave to somebody more familiar with unit dependencies.

Yes, I will do it. I expect, that length is in this case "character length", so "byte length" is "character length"*sizeof(widechar)

-Laco.

Hans-Peter Diettrich wrote

The mix (or equivalence) of character and byte counts obviously is inappropriate for "wide" versions. Perhaps "sizeof" should read "Length"?

Maybe Delphi supports only UCS-2 and not UTF-16

In our previous episode, Felipe Monteiro de Carvalho said:

Delphi afaik supports UTF-16 as a stringtype (afaik all routines route to system routines that keep track of surrogates), but only provides 2-byte array level access for []

It's the prefered way anyways. First, make a good pascal version, if someone needs it, he can look into creating an assembler one for some cpus.

String encodings should not play a role, when e.g. memory has to be allocated or copied (see SetLength). The MaxLen parameter indicates the number of physical units (bytes or words).

DoDi

Florian Klämpfl wrote / napísal(a):

I posted generic pascal versions in bug report
http://bugs.freepascal.org/view.php?id=19989#bugnotes Please review (and commit if all ok).
Thanks
-Laco.