Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2011-05

Stream bug fixes & refactoring - multiple tickets & patches or one?

3 messages · 3 people ·

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Chad Berchek

Hi all. This is my first message here.

I ran across some bugs working with TInputPipeStream. As I investigated further, I found more and more bugs in various stream classes throughout the RTL and FCL. I have fixed the ones I found and made some structural modifications to help prevent such errors from happening again. I can submit a patch. I also have code for test cases.

What I want to ask is: what is the best way to submit an issue to the bug tracker and submit the patch for review? Would it be better to create multiple tickets, one for each distinct bug, or just create one? As for the patch, it would be best if I could keep it as one, since many of the changes are interrelated and it wouldn't necessarily make sense to make one particular change associated with one specific bug. But I suppose I could also create one patch linked with multiple tickets. There are probably a dozen distinct bugs, but many overlap. Please advise me on how things are done here. Thanks.

Chad Berchek

Reply by email

Unknown author
to Chad Berchek
Chad Berchek wrote 17 lines
Hi all. This is my first message here. I ran across some bugs working with TInputPipeStream. As I investigated further, I found more and more bugs in various stream classes throughout the RTL and FCL. I have fixed the ones I found and made some structural modifications to help prevent such errors from happening again. I can submit a patch. I also have code for test cases. What I want to ask is: what is the best way to submit an issue to the bug tracker and submit the patch for review? Would it be better to create multiple tickets, one for each distinct bug, or just create one? As for the patch, it would be best if I could keep it as one, since many of the changes are interrelated and it wouldn't necessarily make sense to make one particular change associated with one specific bug. But I suppose I could also create one patch linked with multiple tickets. There are probably a dozen distinct bugs, but many overlap. Please advise me on how things are done here. Thanks.

Multiple tickets, please, and you can use the 'related to' feature of the bugtracker to link them together.

Michael.

Reply by email

Marco van de Voort
to Unknown author

In our previous episode, said:

Show quoted text 5 lines
> dozen distinct bugs, but many overlap. Please advise me on how things are > done here. Thanks. Multiple tickets, please, and you can use the 'related to' feature of the bugtracker to link them together.

And please with descriptions and/or tests of what fixes what.

It seems that currently on windows non popipes execution is broken. (after commit of 019325)

I noticed this when investigating 19315, where I couldn't get tprocess to execute anything, when I reverted the commit from 19325 it suddenly started working again.

(though there is also a separate issue with 19315, the new properties' logic on windows is flawed, and the commandline is not completely constructed in all cases)

Reply by email