Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2010-10

Re: unit tests for RTL & FCL + 2 patches

8 messages · 3 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Michael Van Canneyt
to Graeme Geldenhuys: Florian mentioned that the compiler is well tested, and I can see there are many .pp…
Graeme Geldenhuys wrote 8 lines
Hi, Florian mentioned that the compiler is well tested, and I can see there are many .pp files in the src/tests/ hierarchy. Where would I look for the RTL and FCL unit tests? Is it the code in <src>/tests/test/units/fpcunit/? If so, is that all of them, or is there another directory (eg: maybe for FCL) somewhere?

There are almost none. They exist between the other tests, but they are a minority.

Show quoted text 13 lines
Also attached are two patches for the <src>/tests/test/units/fpcunit/ project. patch 001: Allows FPC 2.5.1 to actually compile the test suite patch 002: Changes lazarus project file options - session information is stored in separate .lps file - a unit output director to support multiple targets - a defined output filename that is easily accessible PS: I gather there is no automated running of the above test suites anywhere - like there is for the compiler tests?

No, but I am open for suggestions on how to organize the fpcunit tests.

I will see about applying the patch.

Michael.

Reply by email

Graeme Geldenhuys

Hi,

Florian mentioned that the compiler is well tested, and I can see there are many .pp files in the src/tests/ hierarchy.

Where would I look for the RTL and FCL unit tests? Is it the code in <src>/tests/test/units/fpcunit/? If so, is that all of them, or is there another directory (eg: maybe for FCL) somewhere?

Also attached are two patches for the <src>/tests/test/units/fpcunit/ project.

patch 001: Allows FPC 2.5.1 to actually compile the test suite

patch 002: Changes lazarus project file options
- session information is stored in separate .lps file
- a unit output director to support multiple targets
- a defined output filename that is easily accessible

PS:
I gather there is no automated running of the above test suites anywhere - like there is for the compiler tests?

Regards,
- Graeme -

fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal http://opensoft.homeip.net:8080/fpgui/

Reply by email

Michael Van Canneyt
to Graeme Geldenhuys
Graeme Geldenhuys wrote 18 lines
Hi, Florian mentioned that the compiler is well tested, and I can see there are many .pp files in the src/tests/ hierarchy. Where would I look for the RTL and FCL unit tests? Is it the code in <src>/tests/test/units/fpcunit/? If so, is that all of them, or is there another directory (eg: maybe for FCL) somewhere? Also attached are two patches for the <src>/tests/test/units/fpcunit/ project. patch 001: Allows FPC 2.5.1 to actually compile the test suite patch 002: Changes lazarus project file options - session information is stored in separate .lps file - a unit output director to support multiple targets - a defined output filename that is easily accessible

I applied the patch. I don't know how you managed to compile the code, but I fixed that as well.

The test cases were to test the rewrite of the classes/sysutils units, they were not intended for end-user tests. In each case the project compiles now. (and 3 of 204 tests fail. I didn't check whether that's correct or not)

Michael.

Reply by email

Graeme Geldenhuys
to Michael Van Canneyt

Op 2010-10-19 21:55, Michael Van Canneyt het geskryf:

I applied the patch. I don't know how you managed to compile the code, but I fixed that as well.

After applying the changes from patch 001, the project compiled without problems using FPC 2.5.1.

now. (and 3 of 204 tests fail. I didn't check whether that's correct or not)

That is the same results I get. I haven't looked into those failed tests to find out why they fail. I just want to find out what test suites exist for the RTL and FCL at this point.

Regards,
- Graeme -

fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal http://opensoft.homeip.net:8080/fpgui/

Reply by email

Michael Van Canneyt
to Graeme Geldenhuys
Graeme Geldenhuys wrote 7 lines
Op 2010-10-19 21:55, Michael Van Canneyt het geskryf: > > I applied the patch. I don't know how you managed to compile the code, > but I fixed that as well. After applying the changes from patch 001, the project compiled without problems using FPC 2.5.1.

Quite strange, because it contains files that duplicate files in the classes unit.

But no matter. Thanks for the patch.

Michael.

Reply by email

Graeme Geldenhuys
to Michael Van Canneyt

Op 2010-10-20 09:22, Michael Van Canneyt het geskryf:

Quite strange, because it contains files that duplicate files in the classes unit.

I used the testclasses.lpi project file, and the testclasses.lpr only contain tcXXX units in the uses clause, which doesn't seem to conflict anywhere on my system.

But no matter. Thanks for the patch.

My pleasure.

Regards,
- Graeme -

fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal http://opensoft.homeip.net:8080/fpgui/

Reply by email

Jonas Maebe
to Michael Van Canneyt: Quite strange, because it contains files that duplicate files in the classes unit. But no…
Michael Van Canneyt wrote 7 lines
On Wed, 20 Oct 2010, Graeme Geldenhuys wrote: > After applying the changes from patch 001, the project compiled without > problems using FPC 2.5.1. Quite strange, because it contains files that duplicate files in the classes unit.

If the RTL has been compiled with -Ur, which is done automatically when the FPC source tree is built with "make all", this does not cause any problems.

Jonas

Reply by email

Michael Van Canneyt
to Jonas Maebe
Jonas Maebe wrote 12 lines
On 20 Oct 2010, at 09:22, Michael Van Canneyt wrote: > On Wed, 20 Oct 2010, Graeme Geldenhuys wrote: > >> After applying the changes from patch 001, the project compiled without >> problems using FPC 2.5.1. > > Quite strange, because it contains files that duplicate files in the classes > unit. If the RTL has been compiled with -Ur, which is done automatically when the FPC source tree is built with "make all", this does not cause any problems.

Right.
Since I use a development install, this is of course not compiled with -Ur.

Mystery solved. Thanks :-)

Michael.

Reply by email