Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2010-08

last OpenSSL patch breaks the Trunk build

4 messages · 3 people ·

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Graeme Geldenhuys

Hi,

The following change (r15883) breaks Trunk builds. Compiler error on line 2086 (openssl.pas). Expected Pointer but got ShortInt.

------------------------------------------
$ git show HEAD
commit fc8a3f5eee1eda9bf82e7e720789c4fab3835785
Author: Felipe Monteiro de Carvalho
Date: Mon Aug 23 14:32:31 2010 +0000

Small fix for PPEVP_PKEY

git-svn-id: 3ad0048d-3df7-031

diff --git a/packages/openssl/src/openssl.pas b/packages/openssl/src/openssl.pas
index 6172cf8..9bff87a 100644
--- a/packages/openssl/src/openssl.pas
+++ b/packages/openssl/src/openssl.pas
@@ -109,7 +109,7 @@ type
   PBIO_METHOD = SslPtr;
   PBIO = SslPtr;
   PEVP_PKEY = SslPtr;
-  PPEVP_PKEY = PEVP_PKEY;
+  PPEVP_PKEY = ^PEVP_PKEY;
   PRSA = SslPtr;
   PPRSA = ^PRSA;
   PASN1_UTCTIME = SslPtr;

----------------------------------------------------

Attached is a patch to fix the build. I don't know the OpenSSL code so don't know if a simple cast is ok, or if nil should have been return. I went with the cast.

Regards,   - Graeme - _______________________________________________ fpGUI - a cross-platform Free Pascal GUI toolkit http://opensoft.homeip.net/fpgui/

Reply by email

Jonas Maebe
to Jonas Maebe
Jonas Maebe wrote 6 lines
On 23 Aug 2010, at 18:27, Graeme Geldenhuys wrote: > The following change (r15883) breaks Trunk builds. It was already fixed in r15884

Oops, no, it was an error in r15882 and the fix in r15883 causes this problem.

Jonas

Reply by email