Hi,

Attached is a partial patch for 'utils/debugsvr/debugserverintf.pp' unit. This unit is cannot be compiled at the moment, but the attached patch at least removes many of the compiler errors.

There are still 5 remaining compiler errors that I am not sure about how to fix. Can anybody help with these?

I tried with FPC 2.4.0-rc1 and FPC 2.5.1 and neither version of debugserverintf.pp seems to compile.

-------------------------------
/opt/fpc_2.3.1/src/utils/debugsvr/debugserverintf.pp(30,13) Hint: Type "Thandle" redefinition
/opt/fpc_2.3.1/src/utils/debugsvr/debugserverintf.pp(122,3) Warning: Symbol "Str2UnixSockAddr" is deprecated
/opt/fpc_2.3.1/src/utils/debugsvr/debugserverintf.pp(122,47) Hint: Local variable "AddrLen" does not seem to be initialized /opt/fpc_2.3.1/src/utils/debugsvr/debugserverintf.pp(122,39) Hint: Local variable "FUnixAddr" does not seem to be initialized /opt/fpc_2.3.1/src/utils/debugsvr/debugserverintf.pp(123,34) Error: Incompatible type for arg no. 2: Got "TUnixSockAddr", expected "psockaddr"
/opt/fpc_2.3.1/src/utils/debugsvr/debugserverintf.pp(125,6) Error: Boolean expression expected, but got "LongInt"
/opt/fpc_2.3.1/src/utils/debugsvr/debugserverintf.pp(175,34) Error: Incompatible type for arg no. 2: Got "sockaddr_in", expected "psockaddr"
/opt/fpc_2.3.1/src/utils/debugsvr/debugserverintf.pp(176,48) Warning: Local variable "FFileName" does not seem to be initialized /opt/fpc_2.3.1/src/utils/debugsvr/debugserverintf.pp(177,6) Error: Boolean expression expected, but got "LongInt"
/opt/fpc_2.3.1/src/utils/debugsvr/debugserverintf.pp(244,42) Error: Incompatible type for arg no. 3: Got "LongInt", expected "pSockLen" /opt/fpc_2.3.1/src/utils/debugsvr/debugserverintf.pp(344,10) Hint: Local variable "FDebugMessage" does not seem to be initialized /opt/fpc_2.3.1/src/utils/debugsvr/debugserverintf.pp(358,32) Hint: Local variable "msgSize" does not seem to be initialized /opt/fpc_2.3.1/src/utils/debugsvr/debugserverintf.pp(376,32) Hint: Local variable "Event" does not seem to be initialized /opt/fpc_2.3.1/src/utils/debugsvr/debugserverintf.pp(381) Fatal: There were 5 errors compiling module, stopping

-------------------------------

Strange,

I thought I'd fixed this problem a long time ago ??

I'll have another look.

Michael.

2009/12/7 Michael Van Canneyt :

I'll have another look.

Thanks Michael. Like I said, the patch fixes most of the compiler errors, but the last 5 erros expect different types which I'm not sure how to fix - the current implementation doesn't look like it's cross-platform enabled.

Is the debugserverintf unit supposed to work on all platforms?

What is also weird, is the GUI debug server included with Lazarus, doesn't use this unit at all! The Lazarus implementation seems to use sockets directly or something.

No, it uses the simpleipc unit.

There was an old version of the debugintf/server units, but they should no longer be used; I think you're using the old versions.

All units should be in fcl-process and fcl-base, I think ?

Michael.

2009/12/8 Michael Van Canneyt :

I was looking at the GTK1 GUI debugserver application, and wanted to implement a fpGUI version of that server. The code I was looking at is located at:

<fpc_src>/utils/debugsvr/debugintf.pp
<fpc_src>/utils/debugsvr/debugserverintf.pp
<fpc_src>/utils/debugsvr/gtk/*

So are you saying that all debug server applications like the Lazarus one, GTK1 (included with FPC and Console (also included with FPC) should rather use the 'simpleipc' unit to communicate?

So what is the use of the 'debugserverintf' unit, or is that unit actually deprecated?

All units should be in fcl-process and fcl-base, I think ?

'simpleipc' is located in fcl-process.

Um, I just noticed there are two units called dbugintf.pp in FPC source...

packages/fcl-process/dbugintf.pp
and
utils/debugsvr/debugintf.pp

Shouldn't one of them be deleted? The 'utils/debugsvr/*' code looks older and is not based on SimpleIPC, so maybe that should be deleted to avoid further confusion?

Yes, I will do so.

Michael.

Michael Van Canneyt wrote

Strange, I thought I'd fixed this problem a long time ago ??

True, but I said that I would do it.

I have another patch, that removes the file completely. It's obsolete for years and didn't work either.

You have to use the example in packages/fcl-base

Joost

Ah, you already noticed...

Joost.

Joost van der Sluis wrote

I have another patch, that removes the file completely. It's obsolete for years and didn't work either.

:-) A much better patch then.

You have to use the example in packages/fcl-base

Thanks, Michael mentioned that.

Regards,
- Graeme -