Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2009-02

A note on Mantis issue 13173

7 messages · 3 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Sergei Gorelkin

Hello,

Looking at the changes to rtl/win/tthread.inc made in r12761, I see that 'thread helper window' is pretty well unused, as CM_EXECPROC message is never posted to it (grepping rtl sources for CM_EXECPROC shows that). So maybe ThreadWndProc function and window creation/destruction code in AddThread and RemoveThread procedures should be removed?

Regards,
Sergei

Reply by email

Florian Klaempfl
to Sergei Gorelkin
Show quoted text 7 lines
Hello, Looking at the changes to rtl/win/tthread.inc made in r12761, I see that 'thread helper window' is pretty well unused, as CM_EXECPROC message is never posted to it (grepping rtl sources for CM_EXECPROC shows that). So maybe ThreadWndProc function and window creation/destruction code in AddThread and RemoveThread procedures should be removed?

Better add this to the bug report itself.

Reply by email

Sergei Gorelkin
to Florian Klaempfl: Better add this to the bug report itself.
Florian Klaempfl wrote 10 lines
Sergei Gorelkin schrieb: > Hello, > > Looking at the changes to rtl/win/tthread.inc made in r12761, I see that > 'thread helper window' is pretty well unused, as CM_EXECPROC message is > never posted to it (grepping rtl sources for CM_EXECPROC shows that). > So maybe ThreadWndProc function and window creation/destruction code in > AddThread and RemoveThread procedures should be removed? Better add this to the bug report itself.

Unfortunately, it isn't possible to add anything to the bug report once it is resolved. That's why I wrote here.

Sergei

Reply by email

Sergei Gorelkin
to Micha Nelissen: TThread.Synchronize is supposed to use it. Micha
Micha Nelissen wrote 7 lines
Sergei Gorelkin wrote: > Looking at the changes to rtl/win/tthread.inc made in r12761, I see that > 'thread helper window' is pretty well unused, as CM_EXECPROC message > is never posted to it (grepping rtl sources for CM_EXECPROC shows that). TThread.Synchronize is supposed to use it.

It probably was so a while ago, but the current implementation uses a platform-independent mechanism (TThread.Synchronize is entirely in rtl/objpas/classes/classes.inc).

Regards,
Sergei

Reply by email

Micha Nelissen
to Sergei Gorelkin
Sergei Gorelkin wrote 5 lines
> TThread.Synchronize is supposed to use it. > It probably was so a while ago, but the current implementation uses a platform-independent mechanism (TThread.Synchronize is entirely in rtl/objpas/classes/classes.inc).

Oops, didn't I write that? Good catch.

Micha

Reply by email