Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2008-12

[patch] FPCunit & Dunit compatibility improvements

5 messages · 3 people ·

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Michael Van Canneyt
to Joost van der Sluis: Op vrijdag 05-12-2008 om 11:20 uur [tijdzone +0200], schreef Graeme Geldenhuys: About the…
Joost van der Sluis wrote 7 lines
Op vrijdag 05-12-2008 om 11:20 uur [tijdzone +0200], schreef Graeme Geldenhuys: > See bug report and patch. > > http://bugs.freepascal.org/view.php?id=12753 About the question to merge: no.

Indeed. We are too close to 2.2.4.

But I've applied the patch to trunk, and it will be merged after the release.

The patch introduces some new functions but they are
- not used in the core code, although I think they should be ?
- not tested in the testsuite.
Can we expect patches for this as well ?

Michael.

Reply by email

Graeme Geldenhuys
to Michael Van Canneyt
Michael Van Canneyt wrote
> About the question to merge: no. Indeed. We are too close to 2.2.4. But I've applied the patch to trunk, and it will be merged after the release.

Thanks! And no problem about the merge.

The patch introduces some new functions but they are

Which is why I commented in the bug report that the patch is non-invasive. The patch only adds new methods, it doesn't change exisiting ones.

- not used in the core code, although I think they should be ?

Nothing in FPCUnit uses the DUnit compatibility methods. They are just that - a compatibility interface for existing DUnit projects that want to use FPCunit. A good example of that is the tiOPF project. :-)

- not tested in the testsuite. Can we expect patches for this as well ?

There are no tests for the DUnit compatibility interface. That interface is simply a wrapper for existing FPCunit functions. Most are simply a parameter order change and namechange
eg:
AssertXXX(msg,expected,actual) -> CheckXXX(expecte,actual,msg)

So I don't really see the need for testing the compatibility interface, they simply use already tested FPCunit methods. Not to mention, they are well tested/used in tiOPF project anyway - the last test count being 1500+ for FPC compiler under Linux.

Regards,
- Graeme -

_______________________________________________
fpGUI - a cross-platform Free Pascal GUI toolkit
http://opensoft.homeip.net/fpgui/

Reply by email