Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2008-12

merge rev12290

11 messages · 2 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Felipe Monteiro de Carvalho
to Joost van der Sluis
Joost van der Sluis wrote
Can you explain what the results are when we don't merge the fix? And vice-versa?

For the test case or as a whole?

The test case will crash without the fix.

As a whole the Lazarus Windows CE interface will be unable to automatically detect if the current language works from left-to-right or in the opposite direction. It is also impossible to use the GetLanguageIDs routine under Windows CE because it crashes the application.

The change is rather trivial and therefore very easy to verify it's correctness.

I personally don't use right-to-left texts at the moment, but the bug in this routine makes me need to add an ifdef in the LCL so that the routine isn't called for Windows CE. I would prefer not having the ifdef. Any user software using this routine will also face problems (a crash) when being compiled for Windows CE.

Felipe Monteiro de Carvalho

Reply by email

Joost van der Sluis
to Felipe Monteiro de Carvalho

Op maandag 08-12-2008 om 10:17 uur [tijdzone -0200], schreef Felipe Monteiro de Carvalho:

Show quoted text 22 lines
On Mon, Dec 8, 2008 at 10:04 AM, Joost van der Sluis wrote: > Can you explain what the results are when we don't merge the fix? And > vice-versa? For the test case or as a whole? The test case will crash without the fix. As a whole the Lazarus Windows CE interface will be unable to automatically detect if the current language works from left-to-right or in the opposite direction. It is also impossible to use the GetLanguageIDs routine under Windows CE because it crashes the application. The change is rather trivial and therefore very easy to verify it's correctness. I personally don't use right-to-left texts at the moment, but the bug in this routine makes me need to add an ifdef in the LCL so that the routine isn't called for Windows CE. I would prefer not having the ifdef. Any user software using this routine will also face problems (a crash) when being compiled for Windows CE.

Oh, I thought that it was far more important. That resources didn't work at all without this patch, or so.

So this code is hardly ever called?

Joost

Reply by email

Felipe Monteiro de Carvalho
to Joost van der Sluis
Oh, I thought that it was far more important. That resources didn't work at all without this patch, or so. So this code is hardly ever called?

It is called only once in the LCL initialization and that's where I have put the ifdef.

The recommended code to translate the LCL or an user application also uses the routine, and any use of it will cause a crash.

I don't use the LCL standard translation system, but I suspect many user software do and they will crash.

Felipe Monteiro de Carvalho

Reply by email

Felipe Monteiro de Carvalho
to Felipe Monteiro de Carvalho

reminder.

Felipe Monteiro de Carvalho wrote 17 lines
> Oh, I thought that it was far more important. That resources didn't work > at all without this patch, or so. > > So this code is hardly ever called? It is called only once in the LCL initialization and that's where I have put the ifdef. The recommended code to translate the LCL or an user application also uses the routine, and any use of it will cause a crash. I don't use the LCL standard translation system, but I suspect many user software do and they will crash. -- Felipe Monteiro de Carvalho
Felipe Monteiro de Carvalho

Reply by email

Joost van der Sluis
to Felipe Monteiro de Carvalho

Op dinsdag 16-12-2008 om 08:22 uur [tijdzone -0200], schreef Felipe Monteiro de Carvalho:

reminder.

What for?

Show quoted text 22 lines
On Tue, Dec 9, 2008 at 2:30 PM, Felipe Monteiro de Carvalho wrote: >> Oh, I thought that it was far more important. That resources didn't work >> at all without this patch, or so. >> >> So this code is hardly ever called? > > It is called only once in the LCL initialization and that's where I > have put the ifdef. > > The recommended code to translate the LCL or an user application also > uses the routine, and any use of it will cause a crash. > > I don't use the LCL standard translation system, but I suspect many > user software do and they will crash. > > -- > Felipe Monteiro de Carvalho >

Reply by email

Joost van der Sluis
to Felipe Monteiro de Carvalho

Op dinsdag 16-12-2008 om 10:37 uur [tijdzone -0200], schreef Felipe Monteiro de Carvalho:

On Tue, Dec 16, 2008 at 8:43 AM, Joost van der Sluis wrote: > What for? For an answer if the revision will be merged or not.

It is already is merged. And it broke the fixes-testsuite, but that was my fault and is also fixed meanwhile.

Joost.

Reply by email