Joost van der Sluis wrote 12 lines
Op zondag 23-11-2008 om 14:48 uur [tijdzone -0300], schreef Luiz Americo
Pereira Camara:
> Almost all changes were necessary. From 29 changes only 3 were
> cosmetical. Very far from "mostly".
>
> "It's easier if you send in patches without any layout-changes."
>
It's just much easier. Remove those three space-fixes, and the rename of
Options to LocateOptons from the patch.
AFAIK is not possible to have a method argument and a property with the same name in mode objfpc. Let me know if this changed recently. So the is necessary to rename Options to LocateOptions.
When you're done that, you can read the patch very quickly
The problem is here: "very quickly".
Show quoted text 5 lines
and you see
immediately what is really changed. Without having to disregard about
half the patch.
I just counted. Please show me more then three changes (4 lines at total) with reformatting in a 200 line patch. ALL other changes are necessary.
That's just very usefull if you write the code with more people using a
system like svn. That way everybody is able to review other peoples
revisions very quickly.
Just to know how proceed: by the "way everybody is able to review" and "one change at time" approach do you mean:
http://svn.freepascal.org/cgi-bin/viewvc.cgi?view=rev&revision=12173 or http://svn.freepascal.org/cgi-bin/viewvc.cgi?view=rev&revision=12155 ?
I found at least three different changes in each commit. But maybe i'm wrong because i looked "very quickly".
Show quoted text 12 lines
> Ok. Here's another:
http://bugs.freepascal.org/view.php?id=12698 .
> Expect at least one more.
>
> "And then send the layout-changes in a seperate patch."
>
> I was reformatting only surrounded code. Now i'll do a (big) patch with
> all the reformatting.
>
Ok, I'll commit them if they are ready.
Here's another: http://bugs.freepascal.org/view.php?id=12700
Luiz
