Hello,

So this is not some regular type cast but some hack for Delphi - I fixed this in trunk by also allowing typecasts from enumerations (formerly only integers were allowed) to objects in Delphi mode. Due to the nature of the hack already present it also works on 64 bit platforms. Sorry for taking so much time (and thanks for your perserverance ;)

However, all other objections against typecasting still apply, i.e. it's imho not too clean to typecast and breaks the -CR functionality and has maybe other issues.

Regards,
Thomas

Thanks Thomas, and the turnaround was definitely faster than I'm used to with Borland. :)

However, all other objections against typecasting still apply, i.e. it's imho not too clean to typecast and breaks the -CR functionality and has maybe other issues.

We're still trying to get the whole project compiling, but once that's done I'm sure we'll start looking into using FPC's additional warnings and checks. At that point we can start reducing our reliance on Delphi hacks.

I am curious about the -CR functionality though. I haven't used it before, but according to the User's Guide it "Generates checks when calling methods...". We're not calling any methods of the "objects" in this case, and I'd be surprised if TStrings was doing anything with them other than copying them around, so why wouldn't this be compatible?

Thanks,
Craig

It verifies more than just method calls (that description is not very good: it verifies whether self actually points to a valid object/class instance in case of method calls, and also in some other cases). It however also verifies class type casts (it basically replaces every tclass1(instance) with "instance as tclass1"), and also enables regular range checking at the same time.

That said, I was apparently wrong in saying that classtype(enum) is incompatible with -CR: the check is only inserted if the type casted entity is also a class type.

Jonas

Hi Thomas,

While your arguments are very true, this is a case where braking the rules comes with indeed less danger. Since the TStrings does not delete the objects, using dummy classes etc. requires a lot of support code and making sure at any point a string is deleted the object to be freed. This comes at a lot of extra code, and is extremely error prone. It almost guarantees that a mistake will be made at some point in complex project, and a memory leak is almost certain. "Illegal" typecasting in this case is indeed the lesser of the two evils, still ugly none the less, but I will take safe over ugly any day ;-) .

With best regards,
Boian Mitov

-------------------------------------------------------------------- Mitov Software
http://www.mitov.com
--------------------------------------------------------------------