Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2008-04

childpos streaming fixed

5 messages · 3 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Michael Van Canneyt

Hi,

I hope to have fixed what seems to be the last open bug in the streaming system. Unless there are additional reports, the whole cleanroom implementation will be merged to fixes 2.2 and the release process for 2.2.2 will (finally) be started.

Michael.

Reply by email

Jonas Maebe
to Michael Van Canneyt
Michael Van Canneyt wrote
I hope to have fixed what seems to be the last open bug in the streaming system. Unless there are additional reports, the whole cleanroom implementation will be merged to fixes 2.2 and the release process for 2.2.2 will (finally) be started.

As mentioned by Florian elsewhere, this commit seems to have broken 6 tests in the testsuite last night.

Jonas

Reply by email

C Western
to Jonas Maebe
Jonas Maebe wrote 12 lines
On 12 Apr 2008, at 20:53, Michael Van Canneyt wrote: > I hope to have fixed what seems to be the last open bug in the > streaming system. Unless there are additional reports, the whole > cleanroom implementation will be merged to fixes 2.2 and the release > process for 2.2.2 will (finally) be started. As mentioned by Florian elsewhere, this commit seems to have broken 6 tests in the testsuite last night.

lazarus has problems with a form structure like:

TLogForm = class(TSettingsForm)

TSettingsForm = class(TForm)

where TLogForm has resources but TSettingsForm does not. I think at least part of this is a problem with lazarus that I am investigating, but I have found a crash in the writer because of a missing empty list check - see attached patch

Reply by email

Michael Van Canneyt
to Jonas Maebe: As mentioned by Florian elsewhere, this commit seems to have broken 6 tests in the…
Jonas Maebe wrote 10 lines
On 12 Apr 2008, at 20:53, Michael Van Canneyt wrote: >I hope to have fixed what seems to be the last open bug in the >streaming system. Unless there are additional reports, the whole >cleanroom implementation will be merged to fixes 2.2 and the release >process for 2.2.2 will (finally) be started. As mentioned by Florian elsewhere, this commit seems to have broken 6 tests in the testsuite last night.

Aha. I see. Fixed it.

Michael.

Reply by email

Michael Van Canneyt
to C Western: lazarus has problems with a form structure like: TLogForm = class(TSettingsForm)…
C Western wrote 22 lines
Jonas Maebe wrote: > > On 12 Apr 2008, at 20:53, Michael Van Canneyt wrote: > > > I hope to have fixed what seems to be the last open bug in the > > streaming system. Unless there are additional reports, the whole > > cleanroom implementation will be merged to fixes 2.2 and the release > > process for 2.2.2 will (finally) be started. > > As mentioned by Florian elsewhere, this commit seems to have broken 6 tests > in the testsuite last night. > > lazarus has problems with a form structure like: TLogForm = class(TSettingsForm) TSettingsForm = class(TForm) where TLogForm has resources but TSettingsForm does not. I think at least part of this is a problem with lazarus that I am investigating, but I have found a crash in the writer because of a missing empty list check - see attached patch

Hm. I should have read your mail first :)
Anyway, I also found out what was wrong with it, and fixed it.

Michael.

Reply by email