Hi,
Please fix Mantis 10791 (ObjectBinaryToText broken for reals) and merge to fixes_2_2, it damages the form files. Suggestion: remove the wrong code.

Index: classes.inc
=================================================================== --- classes.inc (revision 10339)
+++ classes.inc (working copy)
@@ -1313,10 +1313,12 @@
vaExtended: begin

             ext:=ReadExtended;
             Str(ext:1:20,S);// Do not use localized strings.

- i:=length(S);
- while S[i]='0' do //1234.5678 is nicer than 1.2345678000000000E+0003
- dec(i);
- SetLength(S,i);
+//
+// does not work 2008-02-08 mse
+// i:=length(S);
+// while S[i]='0' do //1234.5678 is nicer than 1.2345678000000000E+0003
+// dec(i);
+// SetLength(S,i);

             OutLn(S);
           end;
         vaString: begin

Thanks, Martin

Martin Schreiber wrote

Hi, Please fix Mantis 10791 (ObjectBinaryToText broken for reals) and merge to fixes_2_2, it damages the form files. Suggestion: remove the wrong code.

Why not let Giulio fix it?

Vincent

I don't understand.

Martin

The bug got assigned to Giulio (whose patch probably introduced it) only yesterday and why don't you give him the time to properly fix it instead of reverting the patch?

Vincent

10791 was submitted 2008-02-14 and assigned 2008-02-14 to Michael Van Canneyt. The wrong patch has cosmetic reasons only and can savely be reverted.

Martin

Argh! Correction:
10791 was submitted 2008-02-08.

Sorry, Martin

Sorry, I now see that this bug has not yet been assigned yet to Giulio.

Vincent

I attached a patch (which is the same Martin proposed) in core yesterday (I don't have write access to trunk). Maybe it wasn't clear to the others that I couldn't apply it, I'll insist.

Giulio
_________________________________________________________________ Invite your mail contacts to join your friends list with Windows Live Spaces. It's easy! http://spaces.live.com/spacesapi.aspx?wx_action=create&wx_url=/friends.aspx&mkt=en-us

I'll do it tonight. I have some other FPC tasks scheduled, I'll do this one as well.

Michael.