Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2007-08

paszlib makefile

8 messages · 3 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Darius Blaszijk

I noticed that "make distclean" in paszlib not only installs the demos to pp\examples\paszlib but all files in the demo directory like .svn, the makefiles themselves and the rest. I fixed this in the following patch. The makefile in the demo directory should be deleted.

Is this the way to fix this issue? If yes then I will prepare a patch for all other instances where the same problem exists (fv / gtk2 / etc / etc)

Darius

Reply by email

Darius Blaszijk
to Darius Blaszijk

Was there a problem with this patch?

Darius

Darius Blaszijk wrote 23 lines
I noticed that "make distclean" in paszlib not only installs the demos to pp\examples\paszlib but all files in the demo directory like .svn, the makefiles themselves and the rest. I fixed this in the following patch. The makefile in the demo directory should be deleted. Is this the way to fix this issue? If yes then I will prepare a patch for all other instances where the same problem exists (fv / gtk2 / etc / etc) Darius ------------------------------------------------------------------------ _______________________________________________ fpc-devel maillist - http://lists.freepascal.org/mailman/listinfo/fpc-devel ------------------------------------------------------------------------ No virus found in this incoming message. Checked by AVG Free Edition. Version: 7.5.484 / Virus Database: 269.12.2/966 - Release Date: 8/22/2007 9:05 AM

Reply by email

Michael Van Canneyt
to Darius Blaszijk
Darius Blaszijk wrote
Was there a problem with this patch?

No, just that it was forgotten :-/

Can you resend it, then I'll apply it.

Michael.

Show quoted text 30 lines
Darius Darius Blaszijk wrote: > I noticed that "make distclean" in paszlib not only installs the demos > to pp\examples\paszlib but all files in the demo directory like .svn, > the makefiles themselves and the rest. I fixed this in the following > patch. The makefile in the demo directory should be deleted. > > Is this the way to fix this issue? If yes then I will prepare a patch > for all other instances where the same problem exists (fv / gtk2 / etc / > etc) > > Darius > > ------------------------------------------------------------------------ > > _______________________________________________ > fpc-devel maillist - > http://lists.freepascal.org/mailman/listinfo/fpc-devel > ------------------------------------------------------------------------ > > No virus found in this incoming message. > Checked by AVG Free Edition. Version: 7.5.484 / Virus Database: 269.12.2/966 > - Release Date: 8/22/2007 9:05 AM > _______________________________________________ fpc-devel maillist - http://lists.freepascal.org/mailman/listinfo/fpc-devel

Reply by email

Darius Blaszijk
to Michael Van Canneyt
Michael Van Canneyt wrote 9 lines
> Was there a problem with this patch? > No, just that it was forgotten :-/ Can you resend it, then I'll apply it.

:)

Please make sure you agree with the way I implemented it... Otherwise let me know how to do it.

Darius

Reply by email

Jonas Maebe
to Darius Blaszijk
Darius Blaszijk wrote
Please make sure you agree with the way I implemented it... Otherwise let me know how to do it.

Normally, installing is only supported from an "svn export" copy, so one without any .svn directory. It's normal that a demo directory contains a makefile to make the demos themselves.

Jonas

Reply by email

Darius Blaszijk
to Jonas Maebe
Jonas Maebe wrote 10 lines
On 04 Sep 2007, at 20:45, Darius Blaszijk wrote: > Please make sure you agree with the way I implemented it... Otherwise > let me know how to do it. Normally, installing is only supported from an "svn export" copy, so one without any .svn directory. It's normal that a demo directory contains a makefile to make the demos themselves.

So what is the proposed method of installing for a normal SVN tree? I always do make distclean all install, which hangs on the removal of pp\..\paszlib\.svn. That is why I noticed (and tried to adress the problem).

Darius

Show quoted text 7 lines
Jonas _______________________________________________ fpc-devel maillist - http://lists.freepascal.org/mailman/listinfo/fpc-devel

Reply by email

Jonas Maebe
to Darius Blaszijk
Darius Blaszijk wrote 12 lines
Jonas Maebe wrote: > > On 04 Sep 2007, at 20:45, Darius Blaszijk wrote: > >> Please make sure you agree with the way I implemented it... >> Otherwise let me know how to do it. > > Normally, installing is only supported from an "svn export" copy, > so one without any .svn directory. It's normal that a demo > directory contains a makefile to make the demos themselves. > So what is the proposed method of installing for a normal SVN tree?

It's simply not supported (but you can of course do it and then delete .svn directories, as you do currently).

Jonas

Reply by email

Darius Blaszijk
to Jonas Maebe
Jonas Maebe wrote 20 lines
On 04 Sep 2007, at 20:55, Darius Blaszijk wrote: > Jonas Maebe wrote: >> >> On 04 Sep 2007, at 20:45, Darius Blaszijk wrote: >> >>> Please make sure you agree with the way I implemented it... >>> Otherwise let me know how to do it. >> >> Normally, installing is only supported from an "svn export" copy, so >> one without any .svn directory. It's normal that a demo directory >> contains a makefile to make the demos themselves. >> > So what is the proposed method of installing for a normal SVN tree? It's simply not supported (but you can of course do it and then delete .svn directories, as you do currently).

Then it's a bug in the fpcmake don't you think? When I put "demo" in the examplesdir then it just copies the entire demo directory rather than executing the makefile in the demo directory.

Darius

Reply by email