Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2007-08

patch fpmkunit

8 messages · 5 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Darius Blaszijk

I've prepared another patch for fpmkunit. What I've came up with is this:

- added a default manifest filename constant
- implemented archiving to zip using TZipper (only when no user assigned ArchiveFilesProc, because that overrides the command)
- moved a lot of strings to resourcestrings
- added listsources description to help screen
- added filename node to manifest file
- removed .zip from TPackage.GetFileName (reason for this is that if ArchiveFilesProc is assigned it gets a filename without extension, possible other archive formats)
- initialized verbosity to vlInfo
- moved verbosity option check to top
- renamed WriteCmd to LogCmd (function also uses Log instead of writeln)
- renamed WriteOption to LogOption (function also uses Log instead of writeln)
- renamed WriteArgOption to LogArgOption (function also uses Log instead of writeln)
- fixed creation of sources.xml added quatationmarks in packagename (TBuildEngine.GetSourceFiles)

Darius

Reply by email

Michael Van Canneyt
to Darius Blaszijk
Darius Blaszijk wrote 19 lines
I've prepared another patch for fpmkunit. What I've came up with is this: - added a default manifest filename constant - implemented archiving to zip using TZipper (only when no user assigned ArchiveFilesProc, because that overrides the command) - moved a lot of strings to resourcestrings - added listsources description to help screen - added filename node to manifest file - removed .zip from TPackage.GetFileName (reason for this is that if ArchiveFilesProc is assigned it gets a filename without extension, possible other archive formats) - initialized verbosity to vlInfo - moved verbosity option check to top - renamed WriteCmd to LogCmd (function also uses Log instead of writeln) - renamed WriteOption to LogOption (function also uses Log instead of writeln) - renamed WriteArgOption to LogArgOption (function also uses Log instead of writeln) - fixed creation of sources.xml added quatationmarks in packagename (TBuildEngine.GetSourceFiles)

Great job. Applied the fix, thanks !

Michael.

Reply by email

Jonas Maebe
to Michael Van Canneyt
Michael Van Canneyt wrote
> - implemented archiving to zip using TZipper (only when no user > assigned > ArchiveFilesProc, because that overrides the command)

The snapshots were broken last night:

/FPC/home/fpc/snapshot/fpc-2.1/compiler/ppc386 -Ur -Xs -O2 -n -Fu/FPC/ home/fpc/s
napshot/fpc-2.1/rtl/units/i386-linux -Fisrc -FE. -FUunits/i386-linux - di386 -dRE
LEASE src/fpmkunit.pp
Fatal: Can't find unit zipper used by fpmkunit
Fatal: Compilation aborted

Maybe you forgot to commit the zipper unit?

Jonas

Reply by email

Vincent Snijders
to Jonas Maebe
Jonas Maebe wrote 17 lines
On 20 Aug 2007, at 09:27, Michael Van Canneyt wrote: >> - implemented archiving to zip using TZipper (only when no user assigned >> ArchiveFilesProc, because that overrides the command) The snapshots were broken last night: /FPC/home/fpc/snapshot/fpc-2.1/compiler/ppc386 -Ur -Xs -O2 -n -Fu/FPC/home/fpc/s napshot/fpc-2.1/rtl/units/i386-linux -Fisrc -FE. -FUunits/i386-linux -di386 -dRE LEASE src/fpmkunit.pp Fatal: Can't find unit zipper used by fpmkunit Fatal: Compilation aborted Maybe you forgot to commit the zipper unit?

It did work here on i386-linux. I have two zippers: /home/vsds/src/fpc/2.3/packages/fcl-base/src/inc/zipper.pp /home/vsds/src/fpc/2.3/utils/fppkg/fcl20/zipper.pp

Vincent

Reply by email

Michael Van Canneyt
to Jonas Maebe: The snapshots were broken last night: /FPC/home/fpc/snapshot/fpc-2.1/compiler/ppc386 -Ur…
Jonas Maebe wrote 17 lines
On 20 Aug 2007, at 09:27, Michael Van Canneyt wrote: > >- implemented archiving to zip using TZipper (only when no user assigned > >ArchiveFilesProc, because that overrides the command) The snapshots were broken last night: /FPC/home/fpc/snapshot/fpc-2.1/compiler/ppc386 -Ur -Xs -O2 -n -Fu/FPC/home/fpc/s napshot/fpc-2.1/rtl/units/i386-linux -Fisrc -FE. -FUunits/i386-linux -di386 -dRE LEASE src/fpmkunit.pp Fatal: Can't find unit zipper used by fpmkunit Fatal: Compilation aborted Maybe you forgot to commit the zipper unit?

No; It's in fcl-base, and has been since ages.
Probably a missing dependency in the makefile...

Michael.

Reply by email

Unknown author
to Vincent Snijders: It did work here on i386-linux. I have two zippers:…
Show quoted text 23 lines
Jonas Maebe schreef: > > On 20 Aug 2007, at 09:27, Michael Van Canneyt wrote: > >>> - implemented archiving to zip using TZipper (only when no user >>> assigned >>> ArchiveFilesProc, because that overrides the command) > > The snapshots were broken last night: > > /FPC/home/fpc/snapshot/fpc-2.1/compiler/ppc386 -Ur -Xs -O2 -n > -Fu/FPC/home/fpc/s > napshot/fpc-2.1/rtl/units/i386-linux -Fisrc -FE. -FUunits/i386-linux > -di386 -dRE > LEASE src/fpmkunit.pp > Fatal: Can't find unit zipper used by fpmkunit > Fatal: Compilation aborted > > Maybe you forgot to commit the zipper unit? It did work here on i386-linux. I have two zippers: /home/vsds/src/fpc/2.3/packages/fcl-base/src/inc/zipper.pp /home/vsds/src/fpc/2.3/utils/fppkg/fcl20/zipper.pp

The zipper version in fppkg is there for bootstrapping purposes. I suppose that is what went wrong with the snapshot too.
This is why MvC already suggested to ifdef the zipping in fpmkunit. Will send a patch this evening if that is ok.

Darius

Reply by email

Vincent Snijders
to Vincent Snijders: It did work here on i386-linux. I have two zippers:…
Vincent Snijders wrote 21 lines
Jonas Maebe schreef: > > On 20 Aug 2007, at 09:27, Michael Van Canneyt wrote: > >>> - implemented archiving to zip using TZipper (only when no user >>> assigned >>> ArchiveFilesProc, because that overrides the command) > > The snapshots were broken last night: > > /FPC/home/fpc/snapshot/fpc-2.1/compiler/ppc386 -Ur -Xs -O2 -n > -Fu/FPC/home/fpc/s > napshot/fpc-2.1/rtl/units/i386-linux -Fisrc -FE. -FUunits/i386-linux > -di386 -dRE > LEASE src/fpmkunit.pp > Fatal: Can't find unit zipper used by fpmkunit > Fatal: Compilation aborted > > Maybe you forgot to commit the zipper unit? It did work here on i386-linux.

On closer inspection, I get an error, when I do
make packages
This works (at least I don't see an error):
make clean all

It looks as if make all doesn't build packages/fpmkunit

Vincent

Reply by email

Jonas Maebe
to Unknown author: The zipper version in fppkg is there for bootstrapping purposes. I suppose that is what…
Show quoted text 10 lines
> It did work here on i386-linux. I have two zippers: > /home/vsds/src/fpc/2.3/packages/fcl-base/src/inc/zipper.pp > /home/vsds/src/fpc/2.3/utils/fppkg/fcl20/zipper.pp The zipper version in fppkg is there for bootstrapping purposes. I suppose that is what went wrong with the snapshot too. This is why MvC already suggested to ifdef the zipping in fpmkunit. Will send a patch this evening if that is ok.

Sounds good to me.

Jonas

Reply by email