The following patch implements all minizip units according to FPC standards , moves all demos to demo directory and updates the makefile.
Darius
Mailing lists / fpc-devel / 2007-06
paszlib patch
5 messages · 4 people · –
- Unknown author 2
- Daniël Mantione 1
- Darius Blaszijk 1
- Michael Van Canneyt 1
Reply by email Subscribe to this list Your subscription
Read-only archive. Use j and k to move between messages.
The patch needs some reconsideration.
zip.pas (perhaps other units I added also?) have a dependency on zlib. But zlib is in packages/extra and not packages/base like paszlib. Does that mean that zip.pas cannot reside at base/paszlib? Probably yes, unless I remove the dep (if possible). Or should I move the units to zlib itself?
Daniel can you please advise me?
Darius
Show quoted text 8 lines
The following patch implements all minizip units according to FPC
standards , moves all demos to demo directory and updates the makefile.
Darius
_______________________________________________
fpc-devel maillist -
http://lists.freepascal.org/mailman/listinfo/fpc-devel
Show quoted text 6 lines
The patch needs some reconsideration.
zip.pas (perhaps other units I added also?) have a dependency on zlib. But
zlib is in packages/extra and not packages/base like paszlib. Does that
mean that zip.pas cannot reside at base/paszlib? Probably yes, unless I
remove the dep (if possible). Or should I move the units to zlib itself?
You should either remove the dep (that should be possible) or move the files to zlib. Personally, I think it's best to remove the deps.
Michael.
The patch needs some reconsideration. zip.pas (perhaps other units I added also?) have a…
Op Tue, 12 Jun 2007, schreef
Show quoted text 8 lines
The patch needs some reconsideration.
zip.pas (perhaps other units I added also?) have a dependency on zlib. But
zlib is in packages/extra and not packages/base like paszlib. Does that
mean that zip.pas cannot reside at base/paszlib? Probably yes, unless I
remove the dep (if possible). Or should I move the units to zlib itself?
Daniel can you please advise me?
WHy do they have a dependency on zlib? Paszlib should be a drop in replacement for zlib, so I see no need for such a dependency.
Daniël
Ok, then. We have consensus to remove the deps.
I will submit a patch later today.
Darius
Show quoted text 21 lines
Op Tue, 12 Jun 2007, schreef
> The patch needs some reconsideration.
>
> zip.pas (perhaps other units I added also?) have a dependency on zlib.
> But
> zlib is in packages/extra and not packages/base like paszlib. Does that
> mean that zip.pas cannot reside at base/paszlib? Probably yes, unless I
> remove the dep (if possible). Or should I move the units to zlib itself?
>
> Daniel can you please advise me?
WHy do they have a dependency on zlib? Paszlib should be a drop in
replacement for zlib, so I see no need for such a dependency.
Daniël_______________________________________________
fpc-devel maillist -
http://lists.freepascal.org/mailman/listinfo/fpc-devel