Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2007-05

multiply resource files bug (commit 7515)

17 messages · 6 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Павел Ишенин

Hello, FPC developers' list

I've noticed today that Yury resolved old and extremly bad for lazarus bug with multiply resource files. And now it is possible to use more than one res in application.

I dont know magic words, but maybe it is possible to merge this fix into future 2.2 version? This help us to solve some problems in lazarus (xp manifest injection, using res instead of lrs).

Best regards,
Paul Ishenin.

Reply by email

Yury Sidorov
to Павел Ишенин

From: "Павел Ишенин"

Show quoted text 9 lines
Hello, FPC developers' list I've noticed today that Yury resolved old and extremly bad for lazarus bug with multiply resource files. And now it is possible to use more than one res in application. I dont know magic words, but maybe it is possible to merge this fix into future 2.2 version? This help us to solve some problems in lazarus (xp manifest injection, using res instead of lrs).

I would like to see this fix in 2.2 as well.
What other core developers think about it?

Yury.

Reply by email

Michael Van Canneyt
to Yury Sidorov
Yury Sidorov wrote 13 lines
From: "Павел Ишенин" > Hello, FPC developers' list > > I've noticed today that Yury resolved old and extremly bad for lazarus bug > with multiply resource files. And now it is possible to use more than one > res in application. > > I dont know magic words, but maybe it is possible to merge this fix into > future 2.2 version? This help us to solve some problems in lazarus (xp > manifest injection, using res instead of lrs). I would like to see this fix in 2.2 as well. What other core developers think about it?

The answer is the same as for Graeme's request to merge some fpcunit fixes: Normally not, and since it's a rather big change which can have some as yet unknown side-effects, I'd say this one is even less likely.

Michael.

Reply by email

Peter Vreman
to Michael Van Canneyt
you wrote 20 lines
On Wed, 30 May 2007, Yury Sidorov wrote: > From: "Павел Ишенин" > > Hello, FPC developers' list > > > > I've noticed today that Yury resolved old and extremly bad for lazarus bug > > with multiply resource files. And now it is possible to use more than one > > res in application. > > > > I dont know magic words, but maybe it is possible to merge this fix into > > future 2.2 version? This help us to solve some problems in lazarus (xp > > manifest injection, using res instead of lrs). > > I would like to see this fix in 2.2 as well. > What other core developers think about it? The answer is the same as for Graeme's request to merge some fpcunit fixes: Normally not, and since it's a rather big change which can have some as yet unknown side-effects, I'd say this one is even less likely.

I agree, but both patches are good candidates for 2.2.2.

Peter

Reply by email

Michael Van Canneyt
to Peter Vreman
Peter Vreman wrote 26 lines
At 15:04 30-5-2007, you wrote: >On Wed, 30 May 2007, Yury Sidorov wrote: > > > From: "Павел Ишенин" > > > Hello, FPC developers' list > > > > > > I've noticed today that Yury resolved old and extremly bad for > lazarus bug > > > with multiply resource files. And now it is possible to use more than > > > one > > > res in application. > > > > > > I dont know magic words, but maybe it is possible to merge this fix into > > > future 2.2 version? This help us to solve some problems in lazarus (xp > > > manifest injection, using res instead of lrs). > > > > I would like to see this fix in 2.2 as well. > > What other core developers think about it? > >The answer is the same as for Graeme's request to merge some fpcunit fixes: >Normally not, and since it's a rather big change which can have some as >yet unknown side-effects, I'd say this one is even less likely. I agree, but both patches are good candidates for 2.2.2.

Absolutely.

Michael.

Reply by email

Yury Sidorov
to Michael Van Canneyt: The answer is the same as for Graeme's request to merge some fpcunit fixes: Normally not,…

From: "Michael Van Canneyt"

Show quoted text 24 lines
On Wed, 30 May 2007, Yury Sidorov wrote: > From: "Павел Ишенин" > > Hello, FPC developers' list > > > > I've noticed today that Yury resolved old and extremly bad for > > lazarus bug > > with multiply resource files. And now it is possible to use more > > than one > > res in application. > > > > I dont know magic words, but maybe it is possible to merge this > > fix into > > future 2.2 version? This help us to solve some problems in > > lazarus (xp > > manifest injection, using res instead of lrs). > > I would like to see this fix in 2.2 as well. > What other core developers think about it? The answer is the same as for Graeme's request to merge some fpcunit fixes: Normally not, and since it's a rather big change which can have some as yet unknown side-effects, I'd say this one is even less likely.

I dont surprised with the answer :) The bugfix is really changes a lot of code.
Let's wait for 2.2.2.

Yury.

Reply by email

Vincent Snijders
to Yury Sidorov
Yury Sidorov wrote 29 lines
From: "Michael Van Canneyt" > On Wed, 30 May 2007, Yury Sidorov wrote: > > From: "Павел Ишенин" > > > Hello, FPC developers' list > > > > > > I've noticed today that Yury resolved old and extremly bad for > > > lazarus bug > > > with multiply resource files. And now it is possible to use more > > > than one > > > res in application. > > > > > > I dont know magic words, but maybe it is possible to merge this > > > fix into > > > future 2.2 version? This help us to solve some problems in > > > lazarus (xp > > > manifest injection, using res instead of lrs). > > > > I would like to see this fix in 2.2 as well. > > What other core developers think about it? > > The answer is the same as for Graeme's request to merge some fpcunit > fixes: > Normally not, and since it's a rather big change which can have some as > yet unknown side-effects, I'd say this one is even less likely. I dont surprised with the answer :) The bugfix is really changes a lot of code. Let's wait for 2.2.2.

Too bad. IMHO, it is not good for fpc development, that people are going to be dependent on 2.3.1 fixes even before 2.2.0 has been released.

Vincent

Reply by email

Jonas Maebe
to Vincent Snijders
Vincent Snijders wrote
Too bad. IMHO, it is not good for fpc development, that people are going to be dependent on 2.3.1 fixes even before 2.2.0 has been released.

Such situations will always exist, unless we never put out a release.

Jonas

Reply by email

Michael Van Canneyt
to Vincent Snijders: Too bad. IMHO, it is not good for fpc development, that people are going to be dependent…
Vincent Snijders wrote 33 lines
Yury Sidorov schreef: > From: "Michael Van Canneyt" > > On Wed, 30 May 2007, Yury Sidorov wrote: > > > From: "Павел Ишенин" > > > > Hello, FPC developers' list > > > > > > > > I've noticed today that Yury resolved old and extremly bad for > > > > lazarus bug > > > > with multiply resource files. And now it is possible to use more > > > > than one > > > > res in application. > > > > > > > > I dont know magic words, but maybe it is possible to merge this > > > > fix into > > > > future 2.2 version? This help us to solve some problems in > > > > lazarus (xp > > > > manifest injection, using res instead of lrs). > > > > > > I would like to see this fix in 2.2 as well. > > > What other core developers think about it? > > > > The answer is the same as for Graeme's request to merge some fpcunit > > fixes: > > Normally not, and since it's a rather big change which can have some as > > yet unknown side-effects, I'd say this one is even less likely. > > I dont surprised with the answer :) The bugfix is really changes a lot of > code. > Let's wait for 2.2.2. > Too bad. IMHO, it is not good for fpc development, that people are going to be dependent on 2.3.1 fixes even before 2.2.0 has been released.

You can help by
- making sure that 2.2.0 is well tested and bugs identified.
- Getting 2.2.2 out of the door quicklier.

Releasing 2.2 is taking forever. It's almost if not completely the slowest release ever :/

Michael.

Reply by email

Vincent Snijders
to Michael Van Canneyt
Michael Van Canneyt wrote 8 lines
On Wed, 30 May 2007, Vincent Snijders wrote: >> > Too bad. IMHO, it is not good for fpc development, that people are going to be > dependent on 2.3.1 fixes even before 2.2.0 has been released. You can help by

I think I am missing something in your reasoning ...

- making sure that 2.2.0 is well tested and bugs identified.

How does that help me? I can even argue that not merging these fixes to the fixes_2_2 branch makes the fixes_2_2 branch less attractive for me and I will switch to trunk instead, so 2.2.0 is even less tested.

- Getting 2.2.2 out of the door quicklier.

How I can do that? One obvious way is to make sure that there is a critical bug in 2.2.0.

Vincent

Reply by email

Jonas Maebe
to Vincent Snijders
Vincent Snijders wrote
> - making sure that 2.2.0 is well tested and bugs identified. How does that help me?

By ensuring that those bugs can be fixed, and their fixes tested, the chance is very high that those fixes will be in 2.2.2 (unlike in case those bugs are fixed by the time the beta of 2.2.2 is running to its end).

> - Getting 2.2.2 out of the door quicklier. How I can do that? One obvious way is to make sure that there is a critical bug in 2.2.0.

Merging the resources fix may just do that.

Jonas

Reply by email

Vincent Snijders
to Yury Sidorov: From: "Michael Van Canneyt" I dont surprised with the answer :) The bugfix is really…
Yury Sidorov wrote 30 lines
From: "Michael Van Canneyt" > On Wed, 30 May 2007, Yury Sidorov wrote: > > From: "Павел Ишенин" > > > Hello, FPC developers' list > > > > > > I've noticed today that Yury resolved old and extremly bad for > > > lazarus bug > > > with multiply resource files. And now it is possible to use more > > > than one > > > res in application. > > > > > > I dont know magic words, but maybe it is possible to merge this > > > fix into > > > future 2.2 version? This help us to solve some problems in > > > lazarus (xp > > > manifest injection, using res instead of lrs). > > > > I would like to see this fix in 2.2 as well. > > What other core developers think about it? > > The answer is the same as for Graeme's request to merge some fpcunit > fixes: > Normally not, and since it's a rather big change which can have some as > yet unknown side-effects, I'd say this one is even less likely. I dont surprised with the answer :) The bugfix is really changes a lot of code. Let's wait for 2.2.2. Yury.

I might have encountered one of the side-effects.

I compiled Lazarus with some components (rxnew for example), and windres used 470 MB Virtual memory in the task manager. After a while I got this message: Compiling resource ..\units\i386-win32\fpc-res.res D:\FPC\2.0.2\bin\i386-Win32\windres.exe: D:\FPC\2.0.2\bin\i386-Win32\windres.exe : ..\units\i386-win32\fpc-res.res: unexpected end of file Error: Error while linking

Vincent

Reply by email

Vincent Snijders
to Vincent Snijders
Vincent Snijders wrote 42 lines
Yury Sidorov schreef: > From: "Michael Van Canneyt" >> On Wed, 30 May 2007, Yury Sidorov wrote: >> > From: "Павел Ишенин" >> > > Hello, FPC developers' list >> > > >> > > I've noticed today that Yury resolved old and extremly bad for > >> > lazarus bug >> > > with multiply resource files. And now it is possible to use more >> > > than one >> > > res in application. >> > > >> > > I dont know magic words, but maybe it is possible to merge this > >> > fix into >> > > future 2.2 version? This help us to solve some problems in > > >> lazarus (xp >> > > manifest injection, using res instead of lrs). >> > >> > I would like to see this fix in 2.2 as well. >> > What other core developers think about it? >> >> The answer is the same as for Graeme's request to merge some fpcunit >> fixes: >> Normally not, and since it's a rather big change which can have some as >> yet unknown side-effects, I'd say this one is even less likely. > > I dont surprised with the answer :) The bugfix is really changes a lot > of code. > Let's wait for 2.2.2. > > Yury. I might have encountered one of the side-effects. I compiled Lazarus with some components (rxnew for example), and windres used 470 MB Virtual memory in the task manager. After a while I got this message: Compiling resource ..\units\i386-win32\fpc-res.res D:\FPC\2.0.2\bin\i386-Win32\windres.exe: D:\FPC\2.0.2\bin\i386-Win32\windres.exe : ..\units\i386-win32\fpc-res.res: unexpected end of file Error: Error while linking

Update: using windres from fpcbuild\trunk\install\binw32 I have no such problem.

Vincent

Reply by email

Vincent Snijders
to Yury Sidorov: From: "Vincent Snijders" It may be windres bug or some of collected .res files is not…
Yury Sidorov wrote 57 lines
From: "Vincent Snijders" > Vincent Snijders schreef: >> Yury Sidorov schreef: >>> From: "Michael Van Canneyt" >>>> On Wed, 30 May 2007, Yury Sidorov wrote: >>>> > From: "Павел Ишенин" >>>> > > Hello, FPC developers' list >>>> > > >>>> > > I've noticed today that Yury resolved old and extremly bad > > >>>> for > >>>> > lazarus bug >>>> > > with multiply resource files. And now it is possible to use > > >>>> more than one >>>> > > res in application. >>>> > > >>>> > > I dont know magic words, but maybe it is possible to merge > > >>>> this > >>>> > fix into >>>> > > future 2.2 version? This help us to solve some problems in > > >>>> > > >>>> lazarus (xp >>>> > > manifest injection, using res instead of lrs). >>>> > >>>> > I would like to see this fix in 2.2 as well. >>>> > What other core developers think about it? >>>> >>>> The answer is the same as for Graeme's request to merge some >>>> fpcunit fixes: >>>> Normally not, and since it's a rather big change which can have >>>> some as >>>> yet unknown side-effects, I'd say this one is even less likely. >>> >>> I dont surprised with the answer :) The bugfix is really changes a >>> lot of code. >>> Let's wait for 2.2.2. >>> >>> Yury. >> >> I might have encountered one of the side-effects. >> >> I compiled Lazarus with some components (rxnew for example), and >> windres used 470 MB Virtual memory in the task manager. After a while >> I got this message: >> Compiling resource ..\units\i386-win32\fpc-res.res >> D:\FPC\2.0.2\bin\i386-Win32\windres.exe: >> D:\FPC\2.0.2\bin\i386-Win32\windres.exe >> : ..\units\i386-win32\fpc-res.res: unexpected end of file >> Error: Error while linking > > Update: using windres from fpcbuild\trunk\install\binw32 I have no > such problem. It may be windres bug or some of collected .res files is not fully correct... What version each windres have? Can you send me this fpc-res.res file?

I will try to reproduce the problem.

Vincent

Reply by email

Yury Sidorov
to Vincent Snijders: Update: using windres from fpcbuild\trunk\install\binw32 I have no such problem. Vincent

From: "Vincent Snijders"

Show quoted text 50 lines
Vincent Snijders schreef: > Yury Sidorov schreef: >> From: "Michael Van Canneyt" >>> On Wed, 30 May 2007, Yury Sidorov wrote: >>> > From: "Павел Ишенин" >>> > > Hello, FPC developers' list >>> > > >>> > > I've noticed today that Yury resolved old and extremly bad >>> > > for > >>> > lazarus bug >>> > > with multiply resource files. And now it is possible to use >>> > > more than one >>> > > res in application. >>> > > >>> > > I dont know magic words, but maybe it is possible to merge >>> > > this > >>> > fix into >>> > > future 2.2 version? This help us to solve some problems in > >>> > > > >>> lazarus (xp >>> > > manifest injection, using res instead of lrs). >>> > >>> > I would like to see this fix in 2.2 as well. >>> > What other core developers think about it? >>> >>> The answer is the same as for Graeme's request to merge some >>> fpcunit fixes: >>> Normally not, and since it's a rather big change which can have >>> some as >>> yet unknown side-effects, I'd say this one is even less likely. >> >> I dont surprised with the answer :) The bugfix is really changes a >> lot of code. >> Let's wait for 2.2.2. >> >> Yury. > > I might have encountered one of the side-effects. > > I compiled Lazarus with some components (rxnew for example), and > windres used 470 MB Virtual memory in the task manager. After a > while I got this message: > Compiling resource ..\units\i386-win32\fpc-res.res > D:\FPC\2.0.2\bin\i386-Win32\windres.exe: > D:\FPC\2.0.2\bin\i386-Win32\windres.exe > : ..\units\i386-win32\fpc-res.res: unexpected end of file > Error: Error while linking Update: using windres from fpcbuild\trunk\install\binw32 I have no such problem.

It may be windres bug or some of collected .res files is not fully correct...
What version each windres have?
Can you send me this fpc-res.res file?

Yury.

Reply by email

Vincent Snijders
to Yury Sidorov
Yury Sidorov wrote 57 lines
From: "Vincent Snijders" > Vincent Snijders schreef: >> Yury Sidorov schreef: >>> From: "Michael Van Canneyt" >>>> On Wed, 30 May 2007, Yury Sidorov wrote: >>>> > From: "Павел Ишенин" >>>> > > Hello, FPC developers' list >>>> > > >>>> > > I've noticed today that Yury resolved old and extremly bad > > >>>> for > >>>> > lazarus bug >>>> > > with multiply resource files. And now it is possible to use > > >>>> more than one >>>> > > res in application. >>>> > > >>>> > > I dont know magic words, but maybe it is possible to merge > > >>>> this > >>>> > fix into >>>> > > future 2.2 version? This help us to solve some problems in > > >>>> > > >>>> lazarus (xp >>>> > > manifest injection, using res instead of lrs). >>>> > >>>> > I would like to see this fix in 2.2 as well. >>>> > What other core developers think about it? >>>> >>>> The answer is the same as for Graeme's request to merge some >>>> fpcunit fixes: >>>> Normally not, and since it's a rather big change which can have >>>> some as >>>> yet unknown side-effects, I'd say this one is even less likely. >>> >>> I dont surprised with the answer :) The bugfix is really changes a >>> lot of code. >>> Let's wait for 2.2.2. >>> >>> Yury. >> >> I might have encountered one of the side-effects. >> >> I compiled Lazarus with some components (rxnew for example), and >> windres used 470 MB Virtual memory in the task manager. After a while >> I got this message: >> Compiling resource ..\units\i386-win32\fpc-res.res >> D:\FPC\2.0.2\bin\i386-Win32\windres.exe: >> D:\FPC\2.0.2\bin\i386-Win32\windres.exe >> : ..\units\i386-win32\fpc-res.res: unexpected end of file >> Error: Error while linking > > Update: using windres from fpcbuild\trunk\install\binw32 I have no > such problem. It may be windres bug or some of collected .res files is not fully correct... What version each windres have? Can you send me this fpc-res.res file?

Working version (from fpc 2.3.1):
GNU windres 2.16.91 20050827
Copyright 2005 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of the GNU General Public License. This program has absolutely no warranty.

Not working version (from fpc 2.0.2):
GNU windres 2.9.5
Copyright 1997, 1998, 1999 Free Software Foundation, Inc. This program is free software; you may redistribute it under the terms of the GNU General Public License. This program has absolutely no warranty.

Attached is the used fpc-res.res file.

Looking at the version, I think windres is just too old. I never had fpc 2.0.4 installed on this computer, so I am still using the binutils from fpc 2.0.2.

Vincent

Reply by email

Yury Sidorov
to Vincent Snijders

From: "Vincent Snijders"

Show quoted text 41 lines
>>> I compiled Lazarus with some components (rxnew for example), and >>> windres used 470 MB Virtual memory in the task manager. After a >>> while >>> I got this message: >>> Compiling resource ..\units\i386-win32\fpc-res.res >>> D:\FPC\2.0.2\bin\i386-Win32\windres.exe: >>> D:\FPC\2.0.2\bin\i386-Win32\windres.exe >>> : ..\units\i386-win32\fpc-res.res: unexpected end of file >>> Error: Error while linking >> >> Update: using windres from fpcbuild\trunk\install\binw32 I have no >> such problem. > > It may be windres bug or some of collected .res files is not fully > correct... > What version each windres have? > Can you send me this fpc-res.res file? > Working version (from fpc 2.3.1): GNU windres 2.16.91 20050827 Copyright 2005 Free Software Foundation, Inc. This program is free software; you may redistribute it under the terms of the GNU General Public License. This program has absolutely no warranty. Not working version (from fpc 2.0.2): GNU windres 2.9.5 Copyright 1997, 1998, 1999 Free Software Foundation, Inc. This program is free software; you may redistribute it under the terms of the GNU General Public License. This program has absolutely no warranty. Attached is the used fpc-res.res file. Looking at the version, I think windres is just too old. I never had fpc 2.0.4 installed on this computer, so I am still using the binutils from fpc 2.0.2.

Yes. I found that windres 2.9.5 is buggy. It compiles .rc files not 100% properly and this causes crash if several .res files are merged together.

windres 2.16.91 should be used. You need to update your binutils.

Yury.

Reply by email