Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-devel / 2007-01

two changes to fcl 2.0.5

9 messages · 5 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Jesus Reyes

Hi.

I'm finally tired of two bugs in fcl in 2.0.5, it could be possible that these be made/merged back?.

1. TSQLQuery under 2.0.5 stores readonly published property IndexDefs into lazarus lfm file. Lazarus is happy reading back the lfm file if it was compiled with 2.0.5 but if it was compiled with 2.1.1 it complains about the readonly property. I can fix that manually removing the the IndexDefs property from the lfm file, I'm tired of it.

This bug is fixed by this patch:
Index: sqldb.pp
===================================================================
--- sqldb.pp    (revisión: 5681)
+++ sqldb.pp    (copia de trabajo)
@@ -269,7 +269,7 @@
     property UpdateSQL : TStringlist read FUpdateSQL write
FUpdateSQL;
     property InsertSQL : TStringlist read FInsertSQL write
FInsertSQL;
     property DeleteSQL : TStringlist read FDeleteSQL write
FDeleteSQL;
-    property IndexDefs : TIndexDefs read GetIndexDefs;
+    property IndexDefs : TIndexDefs read GetIndexDefs stored false;
     property Params : TParams read FParams write FParams;
     property UpdateMode : TUpdateMode read FUpdateMode write
SetUpdateMode;
     property UsePrimaryKeyAsKey : boolean read FUsePrimaryKeyAsKey
write SetUsePrimaryKeyAsKey;

2. I use some png images in my project, every time that I need to do changes on the form, a get "Invalid horizontal pixel index -1" error message (TImage)" error, this bug is fixed in revision: 5355, what it does?, see:
http://www.freepascal.org/cgi-bin/viewcvs.cgi/trunk/fcl/image/fpwritepng.pp?rev=5355&view=diff&r1=5355&r2=5354&p1=trunk/fcl/image/fpwritepng.pp&p2=/trunk/fcl/image/fpwritepng.pp

What you think?, can this happen?.

Thanks.

Jesus Reyes A.

___________________________________________________________ Do You Yahoo!?
La mejor conexión a Internet y <b >2GB</b> extra a tu correo por $100 al mes. http://net.yahoo.com.mx

Reply by email

Michael Van Canneyt
to Jesus Reyes
Jesus Reyes wrote 39 lines
Hi. I'm finally tired of two bugs in fcl in 2.0.5, it could be possible that these be made/merged back?. 1. TSQLQuery under 2.0.5 stores readonly published property IndexDefs into lazarus lfm file. Lazarus is happy reading back the lfm file if it was compiled with 2.0.5 but if it was compiled with 2.1.1 it complains about the readonly property. I can fix that manually removing the the IndexDefs property from the lfm file, I'm tired of it. This bug is fixed by this patch: Index: sqldb.pp =================================================================== --- sqldb.pp (revisión: 5681) +++ sqldb.pp (copia de trabajo) @@ -269,7 +269,7 @@ property UpdateSQL : TStringlist read FUpdateSQL write FUpdateSQL; property InsertSQL : TStringlist read FInsertSQL write FInsertSQL; property DeleteSQL : TStringlist read FDeleteSQL write FDeleteSQL; - property IndexDefs : TIndexDefs read GetIndexDefs; + property IndexDefs : TIndexDefs read GetIndexDefs stored false; property Params : TParams read FParams write FParams; property UpdateMode : TUpdateMode read FUpdateMode write SetUpdateMode; property UsePrimaryKeyAsKey : boolean read FUsePrimaryKeyAsKey write SetUsePrimaryKeyAsKey; 2. I use some png images in my project, every time that I need to do changes on the form, a get "Invalid horizontal pixel index -1" error message (TImage)" error, this bug is fixed in revision: 5355, what it does?, see: http://www.freepascal.org/cgi-bin/viewcvs.cgi/trunk/fcl/image/fpwritepng.pp?rev=5355&view=diff&r1=5355&r2=5354&p1=trunk/fcl/image/fpwritepng.pp&p2=/trunk/fcl/image/fpwritepng.pp What you think?, can this happen?.

I don't see the use. We're preparing to release 2.2.

In March we do a code freeze and start the release process.

Michael.

Reply by email

Aleš Katona
to Michael Van Canneyt
Show quoted text 5 lines
I don't see the use. We're preparing to release 2.2. In March we do a code freeze and start the release process. Michael.

I think the use is something like january, february, march and possibly april.

That's 4 months of bugs with no choice but 2.1.1

Rather ackward if you ask me.

Ales

Reply by email

Jesus Reyes
to Michael Van Canneyt: I don't see the use. We're preparing to release 2.2. In March we do a code freeze and…
--- Michael Van Canneyt wrote 52 lines
On Thu, 11 Jan 2007, Jesus Reyes wrote: > Hi. > > I'm finally tired of two bugs in fcl in 2.0.5, it could be possible > that these be made/merged back?. > > 1. TSQLQuery under 2.0.5 stores readonly published property IndexDefs > into lazarus lfm file. Lazarus is happy reading back the lfm file if > it was compiled with 2.0.5 but if it was compiled with 2.1.1 it > complains about the readonly property. I can fix that manually > removing the the IndexDefs property from the lfm file, I'm tired of > it. > > This bug is fixed by this patch: > Index: sqldb.pp > =================================================================== > --- sqldb.pp (revisión: 5681) > +++ sqldb.pp (copia de trabajo) > @@ -269,7 +269,7 @@ > property UpdateSQL : TStringlist read FUpdateSQL write > FUpdateSQL; > property InsertSQL : TStringlist read FInsertSQL write > FInsertSQL; > property DeleteSQL : TStringlist read FDeleteSQL write > FDeleteSQL; > - property IndexDefs : TIndexDefs read GetIndexDefs; > + property IndexDefs : TIndexDefs read GetIndexDefs stored false; > property Params : TParams read FParams write FParams; > property UpdateMode : TUpdateMode read FUpdateMode write > SetUpdateMode; > property UsePrimaryKeyAsKey : boolean read FUsePrimaryKeyAsKey > write SetUsePrimaryKeyAsKey; > > 2. I use some png images in my project, every time that I need to do > changes on the form, a get "Invalid horizontal pixel index -1" error > message (TImage)" error, this bug is fixed in revision: 5355, what it > does?, see: >

http://www.freepascal.org/cgi-bin/viewcvs.cgi/trunk/fcl/image/fpwritepng.pp?rev=5355&view=diff&r1=5355&r2=5354&p1=trunk/fcl/image/fpwritepng.pp&p2=/trunk/fcl/image/fpwritepng.pp

Show quoted text 8 lines
> > What you think?, can this happen?. I don't see the use. We're preparing to release 2.2. In March we do a code freeze and start the release process. Michael.

offcourse nobody sees the use until they are tired of it like me.

I really don't understand the argument, what are the technical reason to not do it?, I don't think too much resources will be spent fixing this? (or do you have to start releasing packages with the fix, or fixing documentation?, in such case I understand the negative)

Jesus Reyes A.

___________________________________________________________ Do You Yahoo!?
La mejor conexión a Internet y <b >2GB</b> extra a tu correo por $100 al mes. http://net.yahoo.com.mx

Reply by email

Michael Van Canneyt
to Jesus Reyes
Jesus Reyes wrote 71 lines
--- Michael Van Canneyt escribió: > > > On Thu, 11 Jan 2007, Jesus Reyes wrote: > > > Hi. > > > > I'm finally tired of two bugs in fcl in 2.0.5, it could be > possible > > that these be made/merged back?. > > > > 1. TSQLQuery under 2.0.5 stores readonly published property > IndexDefs > > into lazarus lfm file. Lazarus is happy reading back the lfm file > if > > it was compiled with 2.0.5 but if it was compiled with 2.1.1 it > > complains about the readonly property. I can fix that manually > > removing the the IndexDefs property from the lfm file, I'm tired > of > > it. > > > > This bug is fixed by this patch: > > Index: sqldb.pp > > > =================================================================== > > --- sqldb.pp (revisión: 5681) > > +++ sqldb.pp (copia de trabajo) > > @@ -269,7 +269,7 @@ > > property UpdateSQL : TStringlist read FUpdateSQL write > > FUpdateSQL; > > property InsertSQL : TStringlist read FInsertSQL write > > FInsertSQL; > > property DeleteSQL : TStringlist read FDeleteSQL write > > FDeleteSQL; > > - property IndexDefs : TIndexDefs read GetIndexDefs; > > + property IndexDefs : TIndexDefs read GetIndexDefs stored > false; > > property Params : TParams read FParams write FParams; > > property UpdateMode : TUpdateMode read FUpdateMode write > > SetUpdateMode; > > property UsePrimaryKeyAsKey : boolean read > FUsePrimaryKeyAsKey > > write SetUsePrimaryKeyAsKey; > > > > 2. I use some png images in my project, every time that I need to > do > > changes on the form, a get "Invalid horizontal pixel index -1" > error > > message (TImage)" error, this bug is fixed in revision: 5355, > what it > > does?, see: > > > http://www.freepascal.org/cgi-bin/viewcvs.cgi/trunk/fcl/image/fpwritepng.pp?rev=5355&view=diff&r1=5355&r2=5354&p1=trunk/fcl/image/fpwritepng.pp&p2=/trunk/fcl/image/fpwritepng.pp > > > > What you think?, can this happen?. > > I don't see the use. We're preparing to release 2.2. > > In March we do a code freeze and start the release process. > > Michael. offcourse nobody sees the use until they are tired of it like me. I really don't understand the argument, what are the technical reason to not do it?, I don't think too much resources will be spent fixing this? (or do you have to start releasing packages with the fix, or fixing documentation?, in such case I understand the negative)

Well,

As far as I know, there are no releases or snapshots built of 2.0.5, so why would we update that branch ?

It's not a problem to do so, but I don't see the use, as 2.0.5 is not used by anyone - to my knowledge.

In fact I'm surprised you use it at all !

Michael.

Reply by email

Daniël Mantione
to Michael Van Canneyt

Op Thu, 11 Jan 2007, schreef Michael Van Canneyt:

Well, As far as I know, there are no releases or snapshots built of 2.0.5, so why would we update that branch ?

Oh come on, you should know this. Daily snapshots are being built for Dos, Win32, i386 Linux and x86_64 Linux.

Consider the merge done.

Daniël

Reply by email

Jesus Reyes
to Michael Van Canneyt: As far as I know, there are no releases or snapshots built of 2.0.5, so why would we…
--- Michael Van Canneyt wrote 68 lines
On Thu, 11 Jan 2007, Jesus Reyes wrote: > > --- Michael Van Canneyt escribió: > > > > > > > On Thu, 11 Jan 2007, Jesus Reyes wrote: > > > > > Hi. > > > > > > I'm finally tired of two bugs in fcl in 2.0.5, it could be > > possible > > > that these be made/merged back?. > > > > > > 1. TSQLQuery under 2.0.5 stores readonly published property > > IndexDefs > > > into lazarus lfm file. Lazarus is happy reading back the lfm file > > if > > > it was compiled with 2.0.5 but if it was compiled with 2.1.1 it > > > complains about the readonly property. I can fix that manually > > > removing the the IndexDefs property from the lfm file, I'm tired > > of > > > it. > > > > > > This bug is fixed by this patch: > > > Index: sqldb.pp > > > > > =================================================================== > > > --- sqldb.pp (revisión: 5681) > > > +++ sqldb.pp (copia de trabajo) > > > @@ -269,7 +269,7 @@ > > > property UpdateSQL : TStringlist read FUpdateSQL write > > > FUpdateSQL; > > > property InsertSQL : TStringlist read FInsertSQL write > > > FInsertSQL; > > > property DeleteSQL : TStringlist read FDeleteSQL write > > > FDeleteSQL; > > > - property IndexDefs : TIndexDefs read GetIndexDefs; > > > + property IndexDefs : TIndexDefs read GetIndexDefs stored > > false; > > > property Params : TParams read FParams write FParams; > > > property UpdateMode : TUpdateMode read FUpdateMode write > > > SetUpdateMode; > > > property UsePrimaryKeyAsKey : boolean read > > FUsePrimaryKeyAsKey > > > write SetUsePrimaryKeyAsKey; > > > > > > 2. I use some png images in my project, every time that I need to > > do > > > changes on the form, a get "Invalid horizontal pixel index -1" > > error > > > message (TImage)" error, this bug is fixed in revision: 5355, > > what it > > > does?, see: > > > > > >

http://www.freepascal.org/cgi-bin/viewcvs.cgi/trunk/fcl/image/fpwritepng.pp?rev=5355&view=diff&r1=5355&r2=5354&p1=trunk/fcl/image/fpwritepng.pp&p2=/trunk/fcl/image/fpwritepng.pp

Show quoted text 25 lines
> > > > > > What you think?, can this happen?. > > > > I don't see the use. We're preparing to release 2.2. > > > > In March we do a code freeze and start the release process. > > > > Michael. > > offcourse nobody sees the use until they are tired of it like me. > > I really don't understand the argument, what are the technical reason > to not do it?, I don't think too much resources will be spent fixing > this? (or do you have to start releasing packages with the fix, or > fixing documentation?, in such case I understand the negative) Well, As far as I know, there are no releases or snapshots built of 2.0.5, so why would we update that branch ?

Are you sure?, then how do you explain this:
http://www.freepascal.org/cgi-bin/viewcvs.cgi/branches/fixes_2_0/?sortby=date&sortdir=down#dirlist 46 hours, 2 dayes, 3 weeks, it doesn't look freezed to me.

Show quoted text 7 lines
It's not a problem to do so, but I don't see the use, as 2.0.5 is not used by anyone - to my knowledge. In fact I'm surprised you use it at all ! Michael.

If you don't see a problem to do, why not simply do it?

But, if nobody uses it, why it's being updated?, this simply doesn't match.

I use 2.1.1 and 2.0.5, Why would I use 2.0.4 when 2.0.5 has fixes? I though that was the purpose of it, other way I don't see the need for the branch.

I'm happily using 2.1.1 until I have to debug in both windows and linux, that's for what I use 2.0.5 mostly, but sometimes I forget about it and I keep using it until I made changes and swap machines and try to load the same project.

That makes me wonder, what do you use for developent?, maybe I'm in the wrong way. Please share some tricks.

Jesus Reyes A.

___________________________________________________________ Do You Yahoo!?
La mejor conexión a Internet y <b >2GB</b> extra a tu correo por $100 al mes. http://net.yahoo.com.mx

Reply by email

Daniël Mantione
to Jesus Reyes

Op Thu, 11 Jan 2007, schreef Jesus Reyes:

If you don't see a problem to do, why not simply do it?

They are merged.

But, if nobody uses it, why it's being updated?, this simply doesn't match.

No active development is done, but at request we still do some merges.

I use 2.1.1 and 2.0.5, Why would I use 2.0.4 when 2.0.5 has fixes? I though that was the purpose of it, other way I don't see the need for the branch.

Indeed, allthough I do not recommend people to upgrade unless they have a need for a fix that is in 2.0.5.

Show quoted text 7 lines
I'm happily using 2.1.1 until I have to debug in both windows and linux, that's for what I use 2.0.5 mostly, but sometimes I forget about it and I keep using it until I made changes and swap machines and try to load the same project. That makes me wonder, what do you use for developent?, maybe I'm in the wrong way. Please share some tricks.

Well, 3 weeks ago I changed my laptop from 2.0.4 to 2.0.5 because I wanted to get rid of two IDE bugs I fixed. My other computers still use 2.0.4.

Daniël

Reply by email

Florian Klaempfl
to Daniël Mantione
Show quoted text 18 lines
Op Thu, 11 Jan 2007, schreef Jesus Reyes: > If you don't see a problem to do, why not simply do it? They are merged. > But, if nobody uses it, why it's being updated?, this simply doesn't > match. No active development is done, but at request we still do some merges. > I use 2.1.1 and 2.0.5, Why would I use 2.0.4 when 2.0.5 has fixes? I > though that was the purpose of it, other way I don't see the need for > the branch. Indeed, allthough I do not recommend people to upgrade unless they have a need for a fix that is in 2.0.5.

The branch exists basically because it can't removed anymore, further, when 2.0.4 was released it wasn't clear what the next release will be 2.0.4a because of a heavy bug in 2.0.4, 2.0.6 or 2.1.1. Recently, there were some more merges to it because it might be that a 2.0.4a for go32v2 will be created.

Show quoted text 11 lines
> I'm happily using 2.1.1 until I have to debug in both windows and > linux, that's for what I use 2.0.5 mostly, but sometimes I forget > about it and I keep using it until I made changes and swap machines > and try to load the same project. > > That makes me wonder, what do you use for developent?, maybe I'm in > the wrong way. Please share some tricks. Well, 3 weeks ago I changed my laptop from 2.0.4 to 2.0.5 because I wanted to get rid of two IDE bugs I fixed. My other computers still use 2.0.4.

I use 2.0.4 and 2.1.1 only.

Reply by email