Hi,

Attached is a patch for the fpcUnit's example XSLT files.

Changes:
* Grouping by Test Suites is now supported in the generated HTML
* Cleaned up the fpcunit.css file
* Added a navi.js file, which is the JavaScript required for the grouping. (Depending on others, this could be moved into the fpcunit.xsl file if preferred).

I prefer having as little files as possible, so if you can put it into fpcunit.xsl, that would be nice.

Vincent

OK, will do.

Is this a class for actually doing XSLT transforms on XML? If so what unit / documenation can I find this in?

Kris Leech wrote

Is this a class for actually doing XSLT transforms on XML? If so what unit / documenation can I find this in?

No. The XML generated by fpcUnit can include a stylesheet - the fpcunit.xsl is this stylesheet. The fpcunit.xsl is used to generated HTML output, when the XML file is viewed with a Web Browser.

I also use the 'xsltproc' (a front end script for the libxslt library, available for Linux), to generate the output from the command line (no web browser needed).

What's wrong with the XML standard of FO ? It allows you to generate almost any kind of document (including HTML and PDF) from pure xml data and xslt as template (together with FO template). The benefits are that the CSS styles are properties, so the style itself (when needed) is part of the template rather a whole new section for specific type of document.

Or am I missing something here ?

Ido

Hi,

Attached is a new patch for the XSTL example in fpcUnit. This time the JavaScript in inside the fpcunit.xsl file and not as a separate file. I actually like this more as well.

Regards,
- Graeme -

:-) Sorry, I'm lost. What is FO?

It stand for XSL Formatting Objects (XSL-FO is the full name). It was created in order to allow the use of XML and the generating of universal documents. A very know FOSS thingy that uses it, is docbook.

Here is the basic (bad documented last time I checked) standard: http://www.w3.org/Style/XSL/ . There are several tools that does a good job. One of them host under Apache's foundation called fop. But like 90% of the projects hosted at Apache, it is written in Java (the real down side).

Ido

Ok, well to answer you question. I didn't know of XSL-FO. :-) I'm a fairly newbie when it comes to XSLT. I just knew what it could do, and needed to generate a HTML fpcUnit results page for the tiOPF project's daily builds and a summary email. I Google'd XSLT and found a few tutorials. fpcunit.xsl is the result of that. :-) The xsl file for the summary email is not included in fpcUnit - it's to specific to tiOPF.

As soon as I have some time, I'll read up on the XSL-FO to see if it can improve what I have done so far. If you can spot something obvious, please let me know.

Few things :)
1. When ever it is written (for example) that for border you need: border-inner-top, border-inner-left etc... you can do the same with one command (just like css), although most documents about FO that I found does not write anything about it.

2. Make sure that the DTD that you are using support the feature you wish to use, otherwise the result will not be what you are expecting.

3. You will find your writing a bigger text file then "regular" HTML. But it gives you the power to create many other types of document, from simple text file, to pdf and RTF documents (and more, depends on the engine you are using).
Please also write comments inside to know where something begins and end. It will help you more when the file is all grown and it is almost impossible to find what effects what.

4. Adobe acrobat is really buggy, so if you use PDF, please use more then one type of pdf viewer (stand alone that is) to see result of PDF files .:)

5. XSLT 1 is really bad, and if you can, work with XSLT 2 :)

That's 5 tips for start :)

Ido

Thanks for the reply, I'm guessing we do not have a unit for FPC that can do XSLT?

You are guessing correct. Any contributions in this area are hugely welcome.

An XML mapper tool such as in delphi, written on top of an XSLT unit, would also be welcome ;-)

Michael.

Michael, is this patch already applied?

Vincent

I am using fpcunit to check if all the snapshots are up to date: http://www.hu.freepascal.org/lazarus/testresults/monitor.xml

I see a couple of improvements:
* Add Tests, Failures, Errors, Elapsed time for testsuites too (needs a change in the xmlreporter).
* Color code the test suite line (green, ok, red failures).
* Allow test suites in other testsuites. As I wrote the tests the "Snapshot on scenergy" test suites contains most of the following test suites. So they should be hidden in it, and if I click on the scenergy snapshot, they should become visible, just like the individual test do.
* Show the failure or error message as extra information of the test, so clicking on the test would show it.

What do you think of these improvements? Which ones are you willing to implement? If you don't do them all (in time), I will do the remaining ones.

Vincent

No, I was busy. I'll apply it today.

Michael

Vincent Snijders wrote

I see a couple of improvements:

There is always place for improvement. :-)
The last patch was just the beginning and to get some basics for the grouping working.

* Add Tests, Failures, Errors, Elapsed time for testsuites too (needs a change in the xmlreporter).

It was on my to do list, but didn't get time for it yet. I was only going to add the totol test count and total elapsed time for a testsuit. What is the Failures and Errors, a count of howmany occured in the testsuit?

* Color code the test suite line (green, ok, red failures).

Thought about that as well.

* Allow test suites in other testsuites. As I wrote the tests the "Snapshot on scenergy" test suites contains most of the following test suites. So they should be hidden in it, and if I click on the scenergy snapshot, they should become visible, just like the individual test do.

Dean sent me a patch the other day that allows for nested tests (more that the current two levels). Obviously the xslt file doesn't work with such tests yet. I haven't looked at the patch yet, to see what needs changing.

* Show the failure or error message as extra information of the test, so clicking on the test would show it.

Got this on my todo list as well. I was going to jump to the actual error or failure lower down in the page. Did you have another idea?

What do you think of these improvements? Which ones are you willing to implement? If you don't do them all (in time), I will do the remaining ones.

I'll start with the first two.