Hi,

Is there someone in charge of applying patches to FPC? If so, is that someone on leave?
I have noticed quite a few patches being sent to FPC-Devel mailing list, but hardly any gets applied. 6 months ago, this was a different story. I'm just asking... ;-)

I for one have submitted a few patches and have a few more available, but holding off on the rest for now. None of them have been applied yet. Most were submitted in Aug and then again in Sept.

Title and Date:
----------------------
patch - classes.xml (6 Sept)
patch - prog.tex (30 Aug)
patch - types.pp (6 Sept)

Regards,
- Graeme -

MvC.

patch - types.pp (6 Sept)

Was this patch necessary? I though this was solved differently?

Normally I apply these patches. However, My PC was fried due to a lightning bolt, so I currently don't have the possibility to check things in.

As soon as my PC is functioning, I will apply the patches. To make sure I don't forget this, please send them to me personally.

Michael.

Graeme Geldenhuys wrote

I have noticed quite a few patches being sent to FPC-Devel mailing list, but hardly any gets applied.

It's best to file the patches as bug reports if they are not applied immediately to avoid them being forgotten.

Jonas

Thanks for the reply...

> patch - types.pp (6 Sept) Was this patch necessary? I though this was solved differently?

The first patch for types.pp included two things InflateRect() and a Size() function, so was rejected due to the Size() causing issues and would require a bigger fix than I thought.

I then resubmitted the patch, but with only the InflateRect() function. It is a really small function, but missing from other OS's other than Win32. There was no mention why that function had to be available for Windows only (it's part of the Windows unit - API call).

I created my own function for use in fpGUI and Lazarus created there own function for the LCL. It is being used, just not available in FPC's RTL for some reason.

Regards,
- Graeme -

Thanks Michael...whenever you are ready. I have also had my PC fried by lightning before - now they all run though a surge protector.

I didn't get any feedback so wasn't sure if my emails got through to the mailing list, or if I did something wrong in the patches. :-)

Regards,
- Graeme -

Jonas Maebe wrote

It's best to file the patches as bug reports if they are not applied immediately to avoid them being forgotten.

That's a good idea, thanks.

Graeme.