fpc-2.1.1 r4075
linux-i386

If I understand the purpose of function align
(rtl/inc/{systemh.inc,generic.inc}) correctly, it gives wrong results when used with pointers > $8000000.

Align uses ptrint. Using ptrUint instead works.

I tried using it to align a array to 4k bounds, like this:
p:=getmem(MyAry,sizeof(MyAry)+4096); p:=align(p,4096);

IMO align($80000001,$1000) should give $80001000, but gives $80002000.

Attached is a testcase and a patch.

.. there are similar problems with other align functions:

function aligntoptr in
rtl/inc/dynarr.inc
rtl/inc/variants.pp

aligntoptr($70000001) -> 70000004 //correct
aligntoptr($80000001) -> 80000008 //wrong

These are only relevant to platforms where
$FPC_REQUIRES_PROPER_ALIGNMENT

function align in
compiler/cutils.pas

align($70000001,4) -> 70000004 //correct
align($80000001,4) -> 7FFFFFFC //wrong

function aligntoptr in
rtl/objpas/typinfo.pp
seems to be the only one doing it correctly!!

Regards,
Burkhard

Thanks, Patch Applied

Peter

How to apply the patch? Thank you

Alejandro Lucas Baldres wrote

How to apply the patch? Thank you

It is allready applied to the svn trunk.
If you need to do it by hand, I think "patch -p0 < fixalign.patch" in fpc source dir should do it.

regards
Burkhard